[audit] Security, code quality, missing tests, error handling #5

New issue

Open

opened 2026-03-22 16:41:18 +00:00 by Virgil · 1 comment

Virgil commented

2026-03-22 16:41:18 +00:00

Member

Full audit:

Security: SQL injection, XSS, CSRF bypass, mass assignment, path traversal, insecure deserialization
Code quality: missing strict_types, missing type hints, missing return types
Missing tests: modules/actions without Pest test coverage
Error handling: swallowed exceptions, bare try/catch, missing validation
UK English: American spellings (color→colour, organization→organisation, center→centre)
Coding standards: PSR-12 compliance, Action pattern usage, BelongsToWorkspace scoping
Missing SPDX licence headers (EUPL-1.2)

Report all findings with severity and file:line. Do NOT fix.

Full audit: 1. Security: SQL injection, XSS, CSRF bypass, mass assignment, path traversal, insecure deserialization 2. Code quality: missing strict_types, missing type hints, missing return types 3. Missing tests: modules/actions without Pest test coverage 4. Error handling: swallowed exceptions, bare try/catch, missing validation 5. UK English: American spellings (color→colour, organization→organisation, center→centre) 6. Coding standards: PSR-12 compliance, Action pattern usage, BelongsToWorkspace scoping 7. Missing SPDX licence headers (EUPL-1.2) Report all findings with severity and file:line. Do NOT fix.

Virgil commented

2026-03-22 19:41:33 +00:00

Author

Member

Codex Audit Findings (16 total)

Full report committed as changelog/2026/mar/issue-005-audit.md

Highest Severity

content_briefs schema drift
Broken ai_usage writes/typehints in AI pipeline
Missing content_authors table + wrong author_id relation target
Enum-handling fatals in AIGatewayService
Duplicate auth route shadowing
Missing API resource classes
MCP workspace access gaps
Public SVG upload XSS risk
Non-functional webhook retry flow
Preview link generation unthrottled — no rate limit on token generation (ContentPreviewController.php:26-49)

## Codex Audit Findings (16 total) Full report committed as changelog/2026/mar/issue-005-audit.md ### Highest Severity 1. content_briefs schema drift 2. Broken ai_usage writes/typehints in AI pipeline 3. Missing content_authors table + wrong author_id relation target 4. Enum-handling fatals in AIGatewayService 5. Duplicate auth route shadowing 6. Missing API resource classes 7. MCP workspace access gaps 8. Public SVG upload XSS risk 9. Non-functional webhook retry flow 10. Preview link generation unthrottled — no rate limit on token generation (ContentPreviewController.php:26-49)