finding: Core Activity UI duplicated in core/php-admin and core/php-developer #6

Open
opened 2026-02-21 00:16:39 +00:00 by Clotho · 0 comments
Member

Overlap

src/Core/Activity/ (L1 package) owns the activity data model and provides a Livewire ActivityFeed component registered as core.activity-feed.

However, two standalone repos ship their own activity log admin UI components:

  • core/php-admin: src/Website/Hub/View/Modal/Admin/ActivityLog.php
  • core/php-developer: src/View/Modal/Admin/ActivityLog.php

Both are Livewire Volt/class-based components that query and display activity data in the admin panel.

What Differs

  • Core\Activity ActivityFeed: L1 package component, general-purpose feed
  • core/php-admin ActivityLog: Hub module UI, may include workspace filtering
  • core/php-developer ActivityLog: Developer panel view, likely raw/debug-focused

Risk

  • Three implementations of activity log UI may diverge over time
  • Bug fixes applied to one may not propagate to others
  • Admin panel may display inconsistent activity data depending on which component is rendered

Recommendation

Extract to Core Activity. The src/Core/Activity/ package is the right owner for the canonical admin UI component. core/php-admin and core/php-developer should use/extend the L1 component rather than maintaining their own copies. Consider making ActivityFeed configurable via props (scope, filters) to cover all use cases.

Closes #3

## Overlap `src/Core/Activity/` (L1 package) owns the activity data model and provides a Livewire `ActivityFeed` component registered as `core.activity-feed`. However, two standalone repos ship their own activity log admin UI components: - `core/php-admin`: `src/Website/Hub/View/Modal/Admin/ActivityLog.php` - `core/php-developer`: `src/View/Modal/Admin/ActivityLog.php` Both are Livewire Volt/class-based components that query and display activity data in the admin panel. ## What Differs - **`Core\Activity` `ActivityFeed`**: L1 package component, general-purpose feed - **`core/php-admin` `ActivityLog`**: Hub module UI, may include workspace filtering - **`core/php-developer` `ActivityLog`**: Developer panel view, likely raw/debug-focused ## Risk - Three implementations of activity log UI may diverge over time - Bug fixes applied to one may not propagate to others - Admin panel may display inconsistent activity data depending on which component is rendered ## Recommendation **Extract to Core Activity.** The `src/Core/Activity/` package is the right owner for the canonical admin UI component. `core/php-admin` and `core/php-developer` should use/extend the L1 component rather than maintaining their own copies. Consider making `ActivityFeed` configurable via props (scope, filters) to cover all use cases. Closes #3
Clotho added the
review
discovery
labels 2026-02-21 00:16:39 +00:00
Charon added the
agent-ready
label 2026-02-21 01:31:45 +00:00
Sign in to join this conversation.
No description provided.