core/php-mcp
8
0
Fork 0
Code Issues 31 Pull requests Projects Releases Packages Wiki Activity Actions 3

test: add tests for ToolRateLimiter #12

New issue
Open
opened 2026-02-21 00:59:29 +00:00 by Clotho · 0 comments
Clotho commented 2026-02-21 00:59:29 +00:00
Member
Copy link

Summary

The ToolRateLimiter (src/Mcp/Services/ToolRateLimiter.php) has no unit tests. Rate limiting is a critical security component.

What needs testing

  • Per-tool rate limit enforcement
  • Per-workspace rate limits
  • Rate limit reset after window expiry
  • Rate limit exceeded response (429)
  • Burst allowance configuration
  • Rate limit headers in responses

Files

  • src/Mcp/Services/ToolRateLimiter.php
  • src/Mcp/Tests/Unit/ToolRateLimiterTest.php (to be created)
## Summary The `ToolRateLimiter` (src/Mcp/Services/ToolRateLimiter.php) has no unit tests. Rate limiting is a critical security component. ## What needs testing - Per-tool rate limit enforcement - Per-workspace rate limits - Rate limit reset after window expiry - Rate limit exceeded response (429) - Burst allowance configuration - Rate limit headers in responses ## Files - `src/Mcp/Services/ToolRateLimiter.php` - `src/Mcp/Tests/Unit/ToolRateLimiterTest.php` (to be created)
Clotho added the
review
discovery
testing
 labels 2026-02-21 00:59:29 +00:00
Snider added the
clotho
 label 2026-02-21 01:23:27 +00:00
Charon added the
agent-ready
 label 2026-02-21 01:30:17 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
chore/issue-2-discovery-scan
feat/phase-0-assessment
dev
No results found.
Labels
Clear labels   
P1

Priority 1 - Critical

  
P2

Priority 2 - Important

  
P3

Priority 3 - Nice to have

  
PHP

PHP codebase

  
agent-ready

   
bug

Bug fix

  
clotho

Assigned to Clotho AI agent

  
discovery

Auto-discovered by agent

  
docs

Documentation

  
refactor

Code quality refactoring

  
review

Needs human review

  
security

Security hardening

  
testing

Test coverage

  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
P1
P2
P3
PHP
agent-ready
bug
clotho
discovery
docs
refactor
review
security
testing
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/php-mcp#12
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?