discovery: scan php-mcp and create improvement issues #2

New issue

Closed

opened 2026-02-20 01:51:42 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 01:51:42 +00:00

Member

Objective

Scan this module thoroughly and auto-create issues for everything that needs work.

Process

Read CLAUDE.md and TODO.md if they exist
Scan all source files - look for:
- Missing tests (files in src/ without corresponding test)
- TODO/FIXME/HACK comments in code
- Missing type hints or return types
- Empty methods or stub implementations
- Missing error handling
- Missing or outdated documentation
- Security concerns (SQL injection, XSS, mass assignment)
- Dead code or unused imports
- Missing migrations or seeders
- Config files that need environment variables
Check composer.json for:
- Outdated dependencies
- Missing dev dependencies (testing, analysis tools)
- Autoload paths correctness
Check tests/ for:
- Test coverage gaps
- Missing edge case tests
- Tests that are skipped or incomplete

Creating Issues

For EACH finding, create an issue on forge.lthn.ai:

curl -sf -X POST \
  -H "Authorization: token $FORGE_TOKEN_PROD" \
  -H "Content-Type: application/json" \
  "https://forge.lthn.ai/api/v1/repos/core/php-mcp/issues" \
  -d "{\"title\":\"type: description\",\"body\":\"details\",\"labels\":[52,51]}"

Issue types:

test: add tests for {Class/Method} — missing test coverage
fix: {description} — bugs or broken functionality
refactor: {description} — code quality improvements
security: {description} — security concerns (always label review)
docs: {description} — documentation gaps
chore: {description} — dependency updates, config fixes

Label ALL created issues with discovery. Label security/architectural concerns with review.

Also create ONE summary issue titled roadmap: php-mcp production readiness with a checklist of everything needed.

Branch

Work from dev branch. This is a READ-ONLY scan - create issues, do not modify code.

## Objective Scan this module thoroughly and auto-create issues for everything that needs work. ## Process 1. **Read CLAUDE.md and TODO.md** if they exist 2. **Scan all source files** - look for: - Missing tests (files in src/ without corresponding test) - TODO/FIXME/HACK comments in code - Missing type hints or return types - Empty methods or stub implementations - Missing error handling - Missing or outdated documentation - Security concerns (SQL injection, XSS, mass assignment) - Dead code or unused imports - Missing migrations or seeders - Config files that need environment variables 3. **Check composer.json** for: - Outdated dependencies - Missing dev dependencies (testing, analysis tools) - Autoload paths correctness 4. **Check tests/** for: - Test coverage gaps - Missing edge case tests - Tests that are skipped or incomplete ## Creating Issues For EACH finding, create an issue on forge.lthn.ai: ```bash curl -sf -X POST \ -H "Authorization: token $FORGE_TOKEN_PROD" \ -H "Content-Type: application/json" \ "https://forge.lthn.ai/api/v1/repos/core/php-mcp/issues" \ -d "{\"title\":\"type: description\",\"body\":\"details\",\"labels\":[52,51]}" ``` Issue types: - `test: add tests for {Class/Method}` — missing test coverage - `fix: {description}` — bugs or broken functionality - `refactor: {description}` — code quality improvements - `security: {description}` — security concerns (always label review) - `docs: {description}` — documentation gaps - `chore: {description}` — dependency updates, config fixes Label ALL created issues with `discovery`. Label security/architectural concerns with `review`. Also create ONE summary issue titled `roadmap: php-mcp production readiness` with a checklist of everything needed. ## Branch Work from dev branch. This is a READ-ONLY scan - create issues, do not modify code.