test: add tests for AuditLogService #5

New issue

Open

opened 2026-02-21 00:59:14 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-21 00:59:14 +00:00

Member

Summary

The AuditLogService (src/Mcp/Services/AuditLogService.php) lacks unit tests for its critical security functionality.

What needs testing

record() — audit log entry creation with hash chain
verifyChain() — tamper detection via hash chain verification
export() / exportToCsv() / exportToJson() — export with integrity attestation
getStats() — audit statistics aggregation
registerSensitiveTool() / unregisterSensitiveTool() — sensitive tool management
getSensitiveTools() — list retrieval
requiresConsent() — consent gate for sensitive operations
Hash chain integrity across multiple records
Tamper detection when hash chain is broken

Notes

This is a critical security service — test coverage is essential before production deployment.

Files

src/Mcp/Services/AuditLogService.php
src/Mcp/Models/McpAuditLog.php
src/Mcp/Tests/Unit/AuditLogServiceTest.php (to be created)

## Summary The `AuditLogService` (src/Mcp/Services/AuditLogService.php) lacks unit tests for its critical security functionality. ## What needs testing - `record()` — audit log entry creation with hash chain - `verifyChain()` — tamper detection via hash chain verification - `export()` / `exportToCsv()` / `exportToJson()` — export with integrity attestation - `getStats()` — audit statistics aggregation - `registerSensitiveTool()` / `unregisterSensitiveTool()` — sensitive tool management - `getSensitiveTools()` — list retrieval - `requiresConsent()` — consent gate for sensitive operations - Hash chain integrity across multiple records - Tamper detection when hash chain is broken ## Notes This is a critical security service — test coverage is essential before production deployment. ## Files - `src/Mcp/Services/AuditLogService.php` - `src/Mcp/Models/McpAuditLog.php` - `src/Mcp/Tests/Unit/AuditLogServiceTest.php` (to be created)