[audit] Security, code quality, missing tests, error handling #2

New issue

Open

opened 2026-03-22 16:41:19 +00:00 by Virgil · 1 comment

Virgil commented

2026-03-22 16:41:19 +00:00

Member

Full audit:

Security: SQL injection, XSS, CSRF bypass, mass assignment, path traversal, insecure deserialization
Code quality: missing strict_types, missing type hints, missing return types
Missing tests: modules/actions without Pest test coverage
Error handling: swallowed exceptions, bare try/catch, missing validation
UK English: American spellings (color→colour, organization→organisation, center→centre)
Coding standards: PSR-12 compliance, Action pattern usage, BelongsToWorkspace scoping
Missing SPDX licence headers (EUPL-1.2)

Report all findings with severity and file:line. Do NOT fix.

Full audit: 1. Security: SQL injection, XSS, CSRF bypass, mass assignment, path traversal, insecure deserialization 2. Code quality: missing strict_types, missing type hints, missing return types 3. Missing tests: modules/actions without Pest test coverage 4. Error handling: swallowed exceptions, bare try/catch, missing validation 5. UK English: American spellings (color→colour, organization→organisation, center→centre) 6. Coding standards: PSR-12 compliance, Action pattern usage, BelongsToWorkspace scoping 7. Missing SPDX licence headers (EUPL-1.2) Report all findings with severity and file:line. Do NOT fix.

Virgil commented

2026-03-22 19:50:52 +00:00

Author

Member

Codex Audit Findings

HIGH (3)

Route registration bound to current request host — claims / and /features on any host, route caching freezes to one host (Boot.php:30)
Discovery caching ignores addPath()/register() state — cached results hide new services until manual cache clear (ServiceDiscovery.php:204/:227/:419/:726)
Duplicate service codes silently overwrite — registry contents depend on scan order (ServiceDiscovery.php)

## Codex Audit Findings ### HIGH (3) 1. Route registration bound to current request host — claims / and /features on any host, route caching freezes to one host (Boot.php:30) 2. Discovery caching ignores addPath()/register() state — cached results hide new services until manual cache clear (ServiceDiscovery.php:204/:227/:419/:726) 3. Duplicate service codes silently overwrite — registry contents depend on scan order (ServiceDiscovery.php)