From 9f0d421ae8a947f8f4ea827e3a77e7f7b7958ca8 Mon Sep 17 00:00:00 2001
From: Snider <snider@host.uk.com>
Date: Tue, 17 Mar 2026 09:10:30 +0000
Subject: [PATCH] fix(dx): add strict_types to all PHP files and update
 CLAUDE.md
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add declare(strict_types=1) to 9 PHP files missing it
- Update CLAUDE.md: document composer test/lint scripts
- Update CLAUDE.md: fix lthn/php-api → lthn/api package name
- Fix PSR-12 compliance (Pint: ordered imports, FQCN extraction)

Co-Authored-By: Virgil <virgil@lethean.io>
---
 CLAUDE.md                            |  6 +++---
 app/Providers/AppServiceProvider.php |  2 ++
 bootstrap/app.php                    | 14 +++++++++-----
 bootstrap/providers.php              |  5 ++++-
 config/core.php                      |  2 ++
 database/seeders/DatabaseSeeder.php  |  2 ++
 public/index.php                     |  2 ++
 routes/api.php                       |  2 ++
 routes/console.php                   |  2 ++
 routes/web.php                       |  2 ++
 10 files changed, 30 insertions(+), 9 deletions(-)

diff --git a/CLAUDE.md b/CLAUDE.md
index a443014..c7c7a3a 100644
--- a/CLAUDE.md
+++ b/CLAUDE.md
@@ -51,14 +51,14 @@ php artisan make:mod Blog --web      # Web routes only
 php artisan make:mod Blog --api      # API routes only
 
 # Testing
-vendor/bin/pest                      # Run all tests
+composer test                        # Run all tests (Pest)
 vendor/bin/pest tests/Feature        # Run feature tests only
 vendor/bin/pest --filter="test name" # Run single test by name
 vendor/bin/pest path/to/TestFile.php # Run single test file
 
 # Code quality
+composer lint                        # Fix code style (Pint)
 vendor/bin/pint --dirty              # Format changed files only
-vendor/bin/pint                      # Format all files
 ```
 
 ## Module Structure
@@ -82,7 +82,7 @@ app/Mod/Blog/
 |---------|-----------|---------|
 | `lthn/php` | `Core\` | Framework core, events, module discovery |
 | `lthn/php-admin` | `Core\Admin\` | Admin panel, Livewire modals |
-| `lthn/php-api` | `Core\Api\` | REST API, scopes, rate limiting, webhooks |
+| `lthn/api` | `Core\Api\` | REST API, scopes, rate limiting, webhooks |
 | `lthn/php-mcp` | `Core\Mcp\` | Model Context Protocol for AI agents |
 
 ## Testing
diff --git a/app/Providers/AppServiceProvider.php b/app/Providers/AppServiceProvider.php
index 452e6b6..8325058 100644
--- a/app/Providers/AppServiceProvider.php
+++ b/app/Providers/AppServiceProvider.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace App\Providers;
 
 use Illuminate\Support\ServiceProvider;
diff --git a/bootstrap/app.php b/bootstrap/app.php
index 4687853..040fa84 100644
--- a/bootstrap/app.php
+++ b/bootstrap/app.php
@@ -1,5 +1,9 @@
 <?php
 
+declare(strict_types=1);
+
+use Core\LifecycleEventProvider;
+use Core\Website\Boot;
 use Illuminate\Foundation\Application;
 use Illuminate\Foundation\Configuration\Exceptions;
 use Illuminate\Foundation\Configuration\Middleware;
@@ -7,10 +11,10 @@ use Illuminate\Foundation\Configuration\Middleware;
 return Application::configure(basePath: dirname(__DIR__))
     ->withProviders([
         // Core PHP Framework
-        \Core\LifecycleEventProvider::class,
-        \Core\Website\Boot::class,
-        \Core\Front\Boot::class,
-        \Core\Mod\Boot::class,
+        LifecycleEventProvider::class,
+        Boot::class,
+        Core\Front\Boot::class,
+        Core\Mod\Boot::class,
     ])
     ->withRouting(
         web: __DIR__.'/../routes/web.php',
@@ -19,7 +23,7 @@ return Application::configure(basePath: dirname(__DIR__))
         health: '/up',
     )
     ->withMiddleware(function (Middleware $middleware) {
-        \Core\Front\Boot::middleware($middleware);
+        Core\Front\Boot::middleware($middleware);
     })
     ->withExceptions(function (Exceptions $exceptions) {
         //
diff --git a/bootstrap/providers.php b/bootstrap/providers.php
index 38b258d..6752799 100644
--- a/bootstrap/providers.php
+++ b/bootstrap/providers.php
@@ -1,5 +1,8 @@
 <?php
 
+declare(strict_types=1);
+use App\Providers\AppServiceProvider;
+
 return [
-    App\Providers\AppServiceProvider::class,
+    AppServiceProvider::class,
 ];
diff --git a/config/core.php b/config/core.php
index 06502fa..9ba817d 100644
--- a/config/core.php
+++ b/config/core.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     /*
     |--------------------------------------------------------------------------
diff --git a/database/seeders/DatabaseSeeder.php b/database/seeders/DatabaseSeeder.php
index df6818f..8409bbc 100644
--- a/database/seeders/DatabaseSeeder.php
+++ b/database/seeders/DatabaseSeeder.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Database\Seeders;
 
 use Illuminate\Database\Seeder;
diff --git a/public/index.php b/public/index.php
index 947d989..d55a3b2 100644
--- a/public/index.php
+++ b/public/index.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Http\Request;
 
 define('LARAVEL_START', microtime(true));
diff --git a/routes/api.php b/routes/api.php
index 9552cfe..2b5da87 100644
--- a/routes/api.php
+++ b/routes/api.php
@@ -1,3 +1,5 @@
 <?php
 
+declare(strict_types=1);
+
 // API routes are registered via Core modules
diff --git a/routes/console.php b/routes/console.php
index d6f3c8b..ca1bbfa 100644
--- a/routes/console.php
+++ b/routes/console.php
@@ -1,3 +1,5 @@
 <?php
 
+declare(strict_types=1);
+
 // Console commands are registered via Core modules
diff --git a/routes/web.php b/routes/web.php
index 86a06c5..7bceeaf 100644
--- a/routes/web.php
+++ b/routes/web.php
@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Support\Facades\Route;
 
 Route::get('/', function () {