perf: fix N+1 query in NamespaceService::groupedForUser #14

New issue

Open

opened 2026-02-20 16:37:28 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 16:37:28 +00:00

Member

Problem

Services/NamespaceService.php::groupedForUser() (lines 245-271) has an N+1 query pattern:

foreach ($user->workspaces()->active()->get() as $workspace) {
    $namespaces = Namespace_::ownedByWorkspace($workspace)
        ->active()->ordered()->get(); // 1 query per workspace!
}

Impact

For a user with N workspaces, this executes N+1 database queries (1 for workspaces, then 1 per workspace for its namespaces). This method is called on every page load where namespace switching is available.

Acceptance Criteria

Rewrite to use a single query with whereIn or eager loading
Load all relevant namespaces in one query, then group by workspace_id in PHP
Add test or comment documenting expected query count

Discovered during automated scan (issue #3)

## Problem `Services/NamespaceService.php::groupedForUser()` (lines 245-271) has an N+1 query pattern: ```php foreach ($user->workspaces()->active()->get() as $workspace) { $namespaces = Namespace_::ownedByWorkspace($workspace) ->active()->ordered()->get(); // 1 query per workspace! } ``` ## Impact For a user with N workspaces, this executes N+1 database queries (1 for workspaces, then 1 per workspace for its namespaces). This method is called on every page load where namespace switching is available. ## Acceptance Criteria - Rewrite to use a single query with `whereIn` or eager loading - Load all relevant namespaces in one query, then group by workspace_id in PHP - Add test or comment documenting expected query count _Discovered during automated scan (issue #3)_