refactor: create WorkspaceMemberRole enum for type safety #24

New issue

Open

opened 2026-02-20 16:38:36 +00:00 by Clotho · 0 comments

Clotho commented

2026-02-20 16:38:36 +00:00

Member

Problem

Models/WorkspaceMember.php uses string constants (ROLE_OWNER, ROLE_ADMIN, ROLE_MEMBER) for role values. PHP 8.1+ backed enums provide better type safety and IDE support.

Acceptance Criteria

Create Enums/WorkspaceMemberRole.php backed enum with cases: Owner, Admin, Member
Update WorkspaceMember model to cast role attribute to the enum
Update all role comparisons throughout the codebase to use enum cases
Ensure Eloquent can store/retrieve the enum correctly
Update WorkspaceTeamService::migrateExistingMembers() to use enum

Discovered during automated scan (issue #3)

## Problem `Models/WorkspaceMember.php` uses string constants (`ROLE_OWNER`, `ROLE_ADMIN`, `ROLE_MEMBER`) for role values. PHP 8.1+ backed enums provide better type safety and IDE support. ## Acceptance Criteria - Create `Enums/WorkspaceMemberRole.php` backed enum with cases: `Owner`, `Admin`, `Member` - Update `WorkspaceMember` model to cast `role` attribute to the enum - Update all role comparisons throughout the codebase to use enum cases - Ensure Eloquent can store/retrieve the enum correctly - Update `WorkspaceTeamService::migrateExistingMembers()` to use enum _Discovered during automated scan (issue #3)_