From 5a1be07c2b2afd5901528ef5200f31480fbacd15 Mon Sep 17 00:00:00 2001
From: Snider <snider@host.uk.com>
Date: Mon, 27 Apr 2026 15:54:09 +0100
Subject: [PATCH] fix(static-analysis): drop missing src/Core/Service/Tests
 path, suppress pending Service module
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

PHPStan + Psalm CI both failed at config-load on dAppCore/php#2 because
src/Core/Service/Tests doesn't exist. Removed that exclude entry from both
configs.

Knock-on: BunnyStorageService implements Core\Service\Contracts\HealthCheckable
which lives in a not-yet-built Core\Service module. PHPStan flagged it via
non-ignorable interface.notFound, Psalm via MissingDependency. Excluded the
file from PHPStan and added directory-scoped MissingDependency suppression to
Psalm covering src/Core/Cdn until the Service module lands.

Also added Front\Client\Boot to the UndefinedClass suppression list (pending
Front\Client frontage subpackage).

Local verification:
  vendor/bin/phpstan analyse --no-progress    → No errors
  vendor/bin/psalm --no-progress              → No errors found
  composer test                                → 245 tests pass

Tracked under core/lint RFC migration: plans/code/core/lint/RFC.md

Co-Authored-By: Cladius Maximus <claude@anthropic.com>
---
 phpstan.neon |  3 ++-
 psalm.xml    | 13 ++++++++++++-
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/phpstan.neon b/phpstan.neon
index 2ab5346..0a08535 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -17,7 +17,8 @@ parameters:
         - src/Core/Tests
         - src/Core/Bouncer/Tests
         - src/Core/Bouncer/Gate/Tests
-        - src/Core/Service/Tests
         - src/Core/Front/Tests
         - src/Mod/Trees
+        # Pending Core\Service module — see plans/code/core/lint/RFC.md migration
+        - src/Core/Cdn/Services/BunnyStorageService.php
     reportUnmatchedIgnoredErrors: false
diff --git a/psalm.xml b/psalm.xml
index 1366687..ef44739 100644
--- a/psalm.xml
+++ b/psalm.xml
@@ -55,9 +55,21 @@
                 <referencedClass name="Core\Tenant\Models\User" />
                 <referencedClass name="Core\Tenant\Services\EntitlementService" />
                 <referencedClass name="Core\Config\Workspace" />
+                <!-- Pending Core\Service module (see plans/code/core/lint/RFC.md) -->
+                <referencedClass name="Core\Service\Contracts\HealthCheckable" />
+                <referencedClass name="Core\Service\HealthCheckResult" />
+                <!-- Pending Front\Client frontage subpackage -->
+                <referencedClass name="Core\Front\Client\Boot" />
             </errorLevel>
         </UndefinedClass>
 
+        <!-- Pending Core\Service module — referenced by Cdn BunnyStorageService and app variant -->
+        <MissingDependency>
+            <errorLevel type="suppress">
+                <directory name="src/Core/Cdn" />
+            </errorLevel>
+        </MissingDependency>
+
         <!-- Suppress false positives from strict type analysis -->
         <NoValue>
             <errorLevel type="suppress">
@@ -82,7 +94,6 @@
             <directory name="src/Core/Input/Tests" />
             <directory name="src/Core/Bouncer/Tests" />
             <directory name="src/Core/Bouncer/Gate/Tests" />
-            <directory name="src/Core/Service/Tests" />
             <directory name="src/Core/Front/Tests" />
             <directory name="src/Mod/Trees" />
         </ignoreFiles>