Charon/blockchain
1
0
Fork 0
forked from lthn/blockchain
Code Pull requests Activity

fixed a rare race condition in get_coinbase_hash_cached() 3

Browse source
This commit is contained in:
sowle 2025-05-22 16:58:34 +03:00
parent 43bde5aa99
commit 296a6c6211
No known key found for this signature in database
GPG key ID: C07A24B2D89D49FC
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/currency_core/blockchain_storage_basic.h
View file

@ -204,8 +204,13 @@ namespace currency
{
// state is 2, cache must be ready, access the cache
std::shared_ptr<crypto::hash> local_coinbase_id = std::atomic_load(&bei.m_cache_coinbase_id);
CHECK_AND_ASSERT_THROW_MES(local_coinbase_id, "internal error: m_cache_coinbase_id is empty");
return *local_coinbase_id;
if (local_coinbase_id)
return *local_coinbase_id;
// this branch is considered to be a rare case with possible race condition during state 1, reset state to 0
bei.m_cache_coinbase_state.store(0);
crypto::hash h = get_transaction_hash(bei.bl.miner_tx);
return h;
}
uint8_t state = 0;