Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): rename pr to peerRegistry in worker_test.go

Browse source 
AX-1 (Predictable Names): the local variable `pr` is an abbreviation
that requires context to decode. Renamed to `peerRegistry` across all
test functions so the type is self-evident at the point of use.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 10:06:24 +01:00
parent f28d1c3c9c
commit 0074577210
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

40
pkg/node/worker_test.go
View file

@ -30,12 +30,12 @@ func TestWorker_NewWorker_Good(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
if worker == nil {
@ -61,12 +61,12 @@ func TestWorker_SetMinerManager_Good(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
mockManager := &mockMinerManager{}
@ -89,12 +89,12 @@ func TestWorker_SetProfileManager(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
mockProfile := &mockProfileManager{}
@ -117,12 +117,12 @@ func TestWorker_HandlePing(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a ping message
@ -176,12 +176,12 @@ func TestWorker_HandleGetStats(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a get_stats message
@ -234,12 +234,12 @@ func TestWorker_HandleStartMiner_NoManager(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a start_miner message
@ -272,12 +272,12 @@ func TestWorker_HandleStopMiner_NoManager(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a stop_miner message
@ -310,12 +310,12 @@ func TestWorker_HandleGetLogs_NoManager(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a get_logs message
@ -348,12 +348,12 @@ func TestWorker_HandleDeploy_Profile(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a deploy message for profile
@ -390,12 +390,12 @@ func TestWorker_HandleDeploy_UnknownType(t *testing.T) {
t.Fatalf("failed to generate identity: %v", err)
}
pr, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
peerRegistry, err := NewPeerRegistryWithPath(t.TempDir() + "/peers.json")
if err != nil {
t.Fatalf("failed to create peer registry: %v", err)
}
transport := NewTransport(nm, pr, DefaultTransportConfig())
transport := NewTransport(nm, peerRegistry, DefaultTransportConfig())
worker := NewWorker(nm, transport)
// Create a deploy message with unknown type