Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): rename ack to acknowledgement in Worker message handlers
Some checks are pending
Security Scan / security (push) Waiting to run
Details
Test / test (push) Waiting to run
Details

Browse source 
AX-1: predictable names over short names. The variable `ack` is an
abbreviation for `acknowledgement` — renamed in all six callsites
within handleStartMiner, handleStopMiner, and handleDeploy so the
name is self-describing without a comment.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 16:50:13 +01:00
parent d798248ed8
commit 1b021a073b
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
pkg/node/worker.go
View file

@ -234,18 +234,18 @@ func (worker *Worker) handleStartMiner(msg *Message) (*Message, error) {
// Start the miner
miner, err := worker.minerManager.StartMiner(payload.MinerType, config)
if err != nil {
ack := MinerAckPayload{
acknowledgement := MinerAckPayload{
Success: false,
Error: err.Error(),
}
return msg.Reply(MsgMinerAck, ack)
return msg.Reply(MsgMinerAck, acknowledgement)
}
ack := MinerAckPayload{
acknowledgement := MinerAckPayload{
Success: true,
MinerName: miner.GetName(),
}
return msg.Reply(MsgMinerAck, ack)
return msg.Reply(MsgMinerAck, acknowledgement)
}
// response, err := worker.handleStopMiner(message)
@ -260,15 +260,15 @@ func (worker *Worker) handleStopMiner(msg *Message) (*Message, error) {
}
err := worker.minerManager.StopMiner(payload.MinerName)
ack := MinerAckPayload{
acknowledgement := MinerAckPayload{
Success: err == nil,
MinerName: payload.MinerName,
}
if err != nil {
ack.Error = err.Error()
acknowledgement.Error = err.Error()
}
return msg.Reply(MsgMinerAck, ack)
return msg.Reply(MsgMinerAck, acknowledgement)
}
// response, err := worker.handleGetLogs(message)
@ -344,19 +344,19 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
}
if err := worker.profileManager.SaveProfile(profile); err != nil {
ack := DeployAckPayload{
acknowledgement := DeployAckPayload{
Success: false,
Name: payload.Name,
Error: err.Error(),
}
return msg.Reply(MsgDeployAck, ack)
return msg.Reply(MsgDeployAck, acknowledgement)
}
ack := DeployAckPayload{
acknowledgement := DeployAckPayload{
Success: true,
Name: payload.Name,
}
return msg.Reply(MsgDeployAck, ack)
return msg.Reply(MsgDeployAck, acknowledgement)
case BundleMiner, BundleFull:
// Determine installation directory
@ -389,7 +389,7 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
}
// Success response
ack := DeployAckPayload{
acknowledgement := DeployAckPayload{
Success: true,
Name: payload.Name,
}
@ -400,7 +400,7 @@ func (worker *Worker) handleDeploy(conn *PeerConnection, msg *Message) (*Message
"miner_path": minerPath,
})
return msg.Reply(MsgDeployAck, ack)
return msg.Reply(MsgDeployAck, acknowledgement)
default:
return nil, &ProtocolError{Code: ErrCodeInvalidMessage, Message: "unknown bundle type: " + payload.BundleType}