Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(ueps): rename writeTLV params tag→tagByte, value→tagValue

Browse source 
AX Principle 1: predictable names over short names. Parameters named
`tag` and `value` lack context; `tagByte` and `tagValue` are
self-documenting and consistent with the naming used in reader.go.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 10:45:25 +01:00
parent 5b6a607018
commit 3153a44a4b
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkg/ueps/packet.go
View file

@ -104,19 +104,19 @@ func (builder *PacketBuilder) MarshalAndSign(sharedSecret []byte) ([]byte, error
// writeTLV(buffer, TagVersion, []byte{0x09})
// writeTLV(buffer, TagIntent, []byte{intentID})
func writeTLV(writer io.Writer, tag uint8, value []byte) error {
// writeTLV(writer, tag, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge
if len(value) > 255 {
func writeTLV(writer io.Writer, tagByte uint8, tagValue []byte) error {
// writeTLV(writer, TagVersion, bytes.Repeat([]byte("x"), 256)) → errTLVValueTooLarge
if len(tagValue) > 255 {
return errTLVValueTooLarge
}
if _, err := writer.Write([]byte{tag}); err != nil {
if _, err := writer.Write([]byte{tagByte}); err != nil {
return err
}
if _, err := writer.Write([]byte{uint8(len(value))}); err != nil {
if _, err := writer.Write([]byte{uint8(len(tagValue))}); err != nil {
return err
}
if _, err := writer.Write(value); err != nil {
if _, err := writer.Write(tagValue); err != nil {
return err
}
return nil