Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(mining): rename mgr to concreteManager (AX Principle 1)

Browse source 
mgr is an abbreviated variable name. AX Principle 1 requires predictable
names over short names — names should not require a comment to explain.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 07:52:05 +01:00
parent 79a48a3a18
commit 64d11df462
No known key found for this signature in database
GPG key ID: AF404715446AEB41
2 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkg/mining/container.go
View file

@ -118,8 +118,8 @@ func (c *Container) Initialize(ctx context.Context) error {
c.eventHub = NewEventHub()
// Wire up event hub to manager
if mgr, ok := c.manager.(*Manager); ok {
mgr.SetEventHub(c.eventHub)
if concreteManager, ok := c.manager.(*Manager); ok {
concreteManager.SetEventHub(c.eventHub)
}
c.initialized = true
@ -184,8 +184,8 @@ func (c *Container) Shutdown(ctx context.Context) error {
}
// 4. Stop miner manager
if mgr, ok := c.manager.(*Manager); ok {
mgr.Stop()
if concreteManager, ok := c.manager.(*Manager); ok {
concreteManager.Stop()
}
// 5. Close database

4
pkg/mining/service.go
View file

@ -428,8 +428,8 @@ func NewService(manager ManagerInterface, listenAddr string, displayAddr string,
go eventHub.Run()
// Wire up event hub to manager for miner events
if mgr, ok := manager.(*Manager); ok {
mgr.SetEventHub(eventHub)
if concreteManager, ok := manager.(*Manager); ok {
concreteManager.SetEventHub(eventHub)
}
// Set up state provider for WebSocket state sync on reconnect