Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(mining): rename mu to mutex in SettingsManager
Some checks failed
Test / test (push) Has been cancelled
Details
Security Scan / security (push) Has been cancelled
Details

Browse source 
AX Principle 1 — predictable names over short names. The mu field
requires context to understand; mutex is self-describing.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 14:19:36 +01:00
parent 8d323f7570
commit 74ebda333d
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

22
pkg/mining/settings_manager.go
View file

@ -91,7 +91,7 @@ func DefaultSettings() *AppSettings {
// settingsManager, err := NewSettingsManager()
// settings := settingsManager.Get()
type SettingsManager struct {
mu sync.RWMutex
mutex sync.RWMutex
settings *AppSettings
settingsPath string
}
@ -125,8 +125,8 @@ func NewSettingsManager() (*SettingsManager, error) {
// if err := settingsManager.Load(); err != nil && !os.IsNotExist(err) { return err }
func (settingsManager *SettingsManager) Load() error {
settingsManager.mu.Lock()
defer settingsManager.mu.Unlock()
settingsManager.mutex.Lock()
defer settingsManager.mutex.Unlock()
data, err := os.ReadFile(settingsManager.settingsPath)
if err != nil {
@ -144,8 +144,8 @@ func (settingsManager *SettingsManager) Load() error {
// if err := settingsManager.Save(); err != nil { return err }
func (settingsManager *SettingsManager) Save() error {
settingsManager.mu.Lock()
defer settingsManager.mu.Unlock()
settingsManager.mutex.Lock()
defer settingsManager.mutex.Unlock()
data, err := json.MarshalIndent(settingsManager.settings, "", " ")
if err != nil {
@ -158,8 +158,8 @@ func (settingsManager *SettingsManager) Save() error {
// settings := settingsManager.Get()
// if settings.Theme == "dark" { ... }
func (settingsManager *SettingsManager) Get() *AppSettings {
settingsManager.mu.RLock()
defer settingsManager.mu.RUnlock()
settingsManager.mutex.RLock()
defer settingsManager.mutex.RUnlock()
// Return a copy to prevent concurrent modification
settingsCopy := *settingsManager.settings
@ -168,8 +168,8 @@ func (settingsManager *SettingsManager) Get() *AppSettings {
// settingsManager.Update(func(s *AppSettings) { s.Theme = "dark" })
func (settingsManager *SettingsManager) Update(fn func(*AppSettings)) error {
settingsManager.mu.Lock()
defer settingsManager.mu.Unlock()
settingsManager.mutex.Lock()
defer settingsManager.mutex.Unlock()
fn(settingsManager.settings)
@ -195,8 +195,8 @@ func (settingsManager *SettingsManager) UpdateWindowState(x, y, width, height in
// state := settingsManager.GetWindowState()
// if state.Maximized { ... }
func (settingsManager *SettingsManager) GetWindowState() WindowState {
settingsManager.mu.RLock()
defer settingsManager.mu.RUnlock()
settingsManager.mutex.RLock()
defer settingsManager.mutex.RUnlock()
return settingsManager.settings.Window
}