Snider/Mining
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ax(node): rename identity test functions to AX TestFilename_Function_{Good,Bad,Ugly} convention

Browse source 
TestNodeIdentity, TestNodeRoles, TestChallengeResponse violated AX Principle 2 (test
naming). Renamed to TestIdentity_NodeManager_Good, TestIdentity_NodeRoles_Good,
TestIdentity_ChallengeResponse_Good to follow the mandatory TestFilename_Function_Good
naming pattern.

Co-Authored-By: Charon <charon@lethean.io>
This commit is contained in:
Claude 2026-04-02 09:45:13 +01:00
parent 349f395cc6
commit a1939ff5f7
No known key found for this signature in database
GPG key ID: AF404715446AEB41
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkg/node/identity_test.go
View file

@ -29,7 +29,7 @@ func setupTestNodeManager(t *testing.T) (*NodeManager, func()) {
return nm, cleanup
}
func TestNodeIdentity(t *testing.T) {
func TestIdentity_NodeManager_Good(t *testing.T) {
t.Run("NewNodeManager", func(t *testing.T) {
nm, cleanup := setupTestNodeManager(t)
defer cleanup()
@ -198,7 +198,7 @@ func TestNodeIdentity(t *testing.T) {
})
}
func TestNodeRoles(t *testing.T) {
func TestIdentity_NodeRoles_Good(t *testing.T) {
tests := []struct {
role NodeRole
expected string
@ -217,7 +217,7 @@ func TestNodeRoles(t *testing.T) {
}
}
func TestChallengeResponse(t *testing.T) {
func TestIdentity_ChallengeResponse_Good(t *testing.T) {
t.Run("GenerateChallenge", func(t *testing.T) {
challenge, err := GenerateChallenge()
if err != nil {