Some checks failed
CI / test (push) Failing after 2s
77+ findings across 9 rounds, 73+ fixed. False positive rate climbing in round 9 — codebase is converging. Co-Authored-By: Virgil <virgil@lethean.io>
1.9 KiB
1.9 KiB
Known Issues — core/agent
Accepted issues from 7 rounds of Codex review. These are acknowledged trade-offs or enhancement requests, not bugs.
API Enhancements (brain/direct.go)
direct.go:134—rememberdropsconfidence,supersedes,expires_infromRememberInput. Standalone clients can't set persistence metadata.direct.go:153—recallnever forwardsfilter.min_confidence. Direct-mode recall can't apply confidence cutoff.direct.go:177—recalldrops API-returned tags, only synthesisessource:*. Callers lose real memory tags.provider.go:303—listforwardslimitas query-string value instead of integer. REST path diverges from MCP contract.
Test Coverage Gaps
pkg/libhas no dedicated tests for template extraction or embedded prompt/task loading.dispatch/review_queue/spawnAgenthave no integration tests. Need test infrastructure for process mocking.drainQueuecomplex logic has no unit tests with filesystem scaffolding.
Conventions
defaultBranchfalls back tomain/masterwhenorigin/HEADunavailable. Acceptable — covers 99% of repos.CODE_PATHinterpreted differently bysyncRepos(repo root) vs rest of tooling (CODE_PATH/core). Known inconsistency.
Async Bridge Returns (brain/provider.go)
provider.go:247— recall HTTP handler forwards to bridge but returns emptyRecallOutput. Results arrive async via WebSocket — by design for the IDE bridge path.provider.go:297— list HTTP handler same pattern. Only affects bridge-mode clients, not DirectSubsystem.
Compile Issues
pkg/setupdoesn't compile — callslib.RenderFile,lib.ListDirTemplates,lib.ExtractDirwhich don't exist yet. Package is not imported by anything.
Changelog
- 2026-03-21: Created from 7 rounds of Codex static review
- 2026-03-21: Updated after 9 total rounds (77+ findings, 73+ fixed, 4 false positives)