[agent/claude:opus] Fix CodeRabbit findings. Verify each against current code, f... #2

Merged

Virgil merged 1 commit from agent/fix-coderabbit-findings--verify-each-aga into main

2026-03-17 14:13:16 +00:00

Virgil commented

2026-03-17 13:46:58 +00:00

Member

Task

Fix CodeRabbit findings. Verify each against current code, fix ONLY if the issue is real. Run tests before committing. Commit: fix(coderabbit): address review findings

IMPORTANT: Do NOT change function signatures in dependency packages (cli, go-io, etc). Only fix code within THIS repo.

pkg/release/publishers/chocolatey.go:231-254 — pushToChocolatey passes credentials via command line args. Use env vars or config instead if possible.
pkg/release/publishers/npm.go:133 — NpmPublisher.dryRunPublish has unused parameter. Remove it.
pkg/build/signing/sign.go:93 — Error from SignChecksums should include checksums file path.
pkg/build/signing/codesign.go:45 — coreerr.E with nil cause, should have a more descriptive error.
pkg/release/publishers/scoop.go:256-261 — Swallows errors from m.Read(customPath). Handle the error.
pkg/build/builders/wails.go:145-151 — Read/Write error paths return raw errors. Wrap with coreerr.E.
pkg/release/publishers/github.go:150-159 — gh CLI checks use coreerr.E with nil cause. Add the actual error.
pkg/build/builders/docker.go — check inline findings.

Agent: claude:opus
Commits: 1
Branch: agent/fix-coderabbit-findings--verify-each-aga

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Fix CodeRabbit findings. Verify each against current code, fix ONLY if the issue is real. Run tests before committing. Commit: fix(coderabbit): address review findings IMPORTANT: Do NOT change function signatures in dependency packages (cli, go-io, etc). Only fix code within THIS repo. 1. pkg/release/publishers/chocolatey.go:231-254 — pushToChocolatey passes credentials via command line args. Use env vars or config instead if possible. 2. pkg/release/publishers/npm.go:133 — NpmPublisher.dryRunPublish has unused parameter. Remove it. 3. pkg/build/signing/sign.go:93 — Error from SignChecksums should include checksums file path. 4. pkg/build/signing/codesign.go:45 — coreerr.E with nil cause, should have a more descriptive error. 5. pkg/release/publishers/scoop.go:256-261 — Swallows errors from m.Read(customPath). Handle the error. 6. pkg/build/builders/wails.go:145-151 — Read/Write error paths return raw errors. Wrap with coreerr.E. 7. pkg/release/publishers/github.go:150-159 — gh CLI checks use coreerr.E with nil cause. Add the actual error. 8. pkg/build/builders/docker.go — check inline findings. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/fix-coderabbit-findings--verify-each-aga` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-17 13:46:58 +00:00

fix(coderabbit): address review findings 49fb446739

- chocolatey: pass API key via env var instead of CLI arg
- npm: remove unused cfg parameter from dryRunPublish
- signing: include checksums file path in error message
- codesign: provide specific reason when codesign unavailable
- scoop: handle error from custom template read
- wails: wrap Read/Write errors with coreerr.E
- github: include actual error in validateGhCli coreerr.E calls
- docker: include actual error in validate/buildx coreerr.E calls

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-17 13:47:07 +00:00

Author

Member

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-build/cmd/build
cmd/build/cmd_build.go:13:41: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
FAIL	forge.lthn.ai/core/go-build/cmd/build [build failed]
?   	forge.lthn.ai/core/go-build/cmd/ci	[no test files]
?   	forge.lthn.ai/core/go-build/cmd/sdk	[no test files]
?   	forge.lthn.ai/core/go-build/locales	[no test files]
ok  	forge.lthn.ai/core/go-build/pkg/api	1.368s
ok  	forge.lthn.ai/core/go-build/pkg/build	1.560s
ok  	forge.lthn.ai/core/go-build/pkg/build/builders	1.886s
ok  	forge.lthn.ai/core/go-build/pkg/build/signing	0.353s
ok  	forge.lthn.ai/core/go-build/pkg/release	6.930s
ok  	forge.lthn.ai/core/go-build/pkg/release/publishers	4.434s
ok  	forge.lthn.ai/core/go-build/pkg/sdk	0.729s
ok  	forge.lthn.ai/core/go-build/pkg/sdk/generators	3.142s
FAIL

Exit code: 1

PR will not be auto-merged.

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-build/cmd/build cmd/build/cmd_build.go:13:41: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) FAIL forge.lthn.ai/core/go-build/cmd/build [build failed] ? forge.lthn.ai/core/go-build/cmd/ci [no test files] ? forge.lthn.ai/core/go-build/cmd/sdk [no test files] ? forge.lthn.ai/core/go-build/locales [no test files] ok forge.lthn.ai/core/go-build/pkg/api 1.368s ok forge.lthn.ai/core/go-build/pkg/build 1.560s ok forge.lthn.ai/core/go-build/pkg/build/builders 1.886s ok forge.lthn.ai/core/go-build/pkg/build/signing 0.353s ok forge.lthn.ai/core/go-build/pkg/release 6.930s ok forge.lthn.ai/core/go-build/pkg/release/publishers 4.434s ok forge.lthn.ai/core/go-build/pkg/sdk 0.729s ok forge.lthn.ai/core/go-build/pkg/sdk/generators 3.142s FAIL ``` **Exit code:** 1 PR will not be auto-merged.