[agent/claude:opus] Fix CodeRabbit findings from PR review. Verify each against ... #4

Closed

Virgil wants to merge 1 commit from agent/fix-coderabbit-findings-from-pr-review into main

Virgil commented

2026-03-17 09:54:27 +00:00

Member

Task

Fix CodeRabbit findings from PR review. Verify each against current code, fix if valid, run tests. Commit: fix(coderabbit): address review findings

deploy/coolify/client.go:84-93 — Error embeds full API response in log.E(), could leak sensitive data. Truncate output to 100 chars before including in error message.
cmd/dev/cmd_tag.go:144-177 — Loop swallows per-repo failures, always returns nil. Change control flow so errors propagate — collect errors and return a combined error or fail on first critical error.

Agent: claude:opus
Commits: 1
Branch: agent/fix-coderabbit-findings-from-pr-review

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Fix CodeRabbit findings from PR review. Verify each against current code, fix if valid, run tests. Commit: fix(coderabbit): address review findings 1. deploy/coolify/client.go:84-93 — Error embeds full API response in log.E(), could leak sensitive data. Truncate output to 100 chars before including in error message. 2. cmd/dev/cmd_tag.go:144-177 — Loop swallows per-repo failures, always returns nil. Change control flow so errors propagate — collect errors and return a combined error or fail on first critical error. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/fix-coderabbit-findings-from-pr-review` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-17 09:54:28 +00:00

fix(coderabbit): address review findings 32b2c3775e

Truncate API response to 100 chars in coolify client error messages
to prevent sensitive data leakage. Propagate per-repo tag failures
as a combined error instead of silently returning nil.

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-17 09:54:29 +00:00

Author

Member

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-devops/cmd/docs
cmd/docs/cmd_commands.go:17:40: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
# forge.lthn.ai/core/go-devops/cmd/setup
cmd/setup/cmd_commands.go:33:41: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
# forge.lthn.ai/core/go-devops/cmd/dev
cmd/dev/cmd_dev.go:42:39: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
# forge.lthn.ai/core/go-devops/cmd/deploy
cmd/deploy/cmd_commands.go:9:42: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
FAIL	forge.lthn.ai/core/go-devops/cmd/deploy [build failed]
FAIL	forge.lthn.ai/core/go-devops/cmd/dev [build failed]
FAIL	forge.lthn.ai/core/go-devops/cmd/docs [build failed]
FAIL	forge.lthn.ai/core/go-devops/cmd/gitcmd [build failed]
FAIL	forge.lthn.ai/core/go-devops/cmd/setup [build failed]
?   	forge.lthn.ai/core/go-devops/deploy/coolify	[no test files]
?   	forge.lthn.ai/core/go-devops/deploy/python	[no test files]
?   	forge.lthn.ai/core/go-devops/locales	[no test files]
ok  	forge.lthn.ai/core/go-devops/snapshot	0.289s
FAIL

Exit code: 1

PR will not be auto-merged.

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-devops/cmd/docs cmd/docs/cmd_commands.go:17:40: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) # forge.lthn.ai/core/go-devops/cmd/setup cmd/setup/cmd_commands.go:33:41: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) # forge.lthn.ai/core/go-devops/cmd/dev cmd/dev/cmd_dev.go:42:39: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) # forge.lthn.ai/core/go-devops/cmd/deploy cmd/deploy/cmd_commands.go:9:42: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) FAIL forge.lthn.ai/core/go-devops/cmd/deploy [build failed] FAIL forge.lthn.ai/core/go-devops/cmd/dev [build failed] FAIL forge.lthn.ai/core/go-devops/cmd/docs [build failed] FAIL forge.lthn.ai/core/go-devops/cmd/gitcmd [build failed] FAIL forge.lthn.ai/core/go-devops/cmd/setup [build failed] ? forge.lthn.ai/core/go-devops/deploy/coolify [no test files] ? forge.lthn.ai/core/go-devops/deploy/python [no test files] ? forge.lthn.ai/core/go-devops/locales [no test files] ok forge.lthn.ai/core/go-devops/snapshot 0.289s FAIL ``` **Exit code:** 1 PR will not be auto-merged.