[agent/codex:gpt-5.4-mini] Read docs/RFC.md fully. Find ONE feature described in the sp... #24

Merged
Virgil merged 1 commit from main into dev 2026-04-03 20:38:13 +00:00
2 changed files with 88 additions and 8 deletions

View file

@ -141,6 +141,81 @@ func TestServiceDiscoverFromMainchainAliasesUsesMainchainThenHSD(t *testing.T) {
}
}
func TestServiceDiscoverFromMainchainAliasesFallsBackToConfiguredMainchainClient(t *testing.T) {
var chainCalls int32
var hsdTreeRootCalls int32
var hsdAliasCalls int32
server := httptest.NewServer(http.HandlerFunc(func(responseWriter http.ResponseWriter, request *http.Request) {
var payload struct {
Method string `json:"method"`
Params []any `json:"params"`
}
if err := json.NewDecoder(request.Body).Decode(&payload); err != nil {
t.Fatalf("unexpected request payload: %v", err)
}
switch payload.Method {
case "get_all_alias_details":
atomic.AddInt32(&chainCalls, 1)
responseWriter.Header().Set("Content-Type", "application/json")
_ = json.NewEncoder(responseWriter).Encode(map[string]any{
"result": []any{
map[string]any{
"hns": "gateway.charon.lthn",
},
},
})
case "getblockchaininfo":
atomic.AddInt32(&hsdTreeRootCalls, 1)
responseWriter.Header().Set("Content-Type", "application/json")
_ = json.NewEncoder(responseWriter).Encode(map[string]any{
"result": map[string]any{
"tree_root": "chain-root-1",
},
})
case "getnameresource":
atomic.AddInt32(&hsdAliasCalls, 1)
responseWriter.Header().Set("Content-Type", "application/json")
_ = json.NewEncoder(responseWriter).Encode(map[string]any{
"result": map[string]any{
"a": []string{"10.10.10.10"},
},
})
default:
t.Fatalf("unexpected method: %s", payload.Method)
}
}))
defer server.Close()
service := NewService(ServiceOptions{
MainchainAliasClient: NewMainchainAliasClient(MainchainClientOptions{
URL: server.URL,
}),
})
hsdClient := NewHSDClient(HSDClientOptions{
URL: server.URL,
})
if err := service.DiscoverFromMainchainAliases(context.Background(), nil, hsdClient); err != nil {
t.Fatalf("expected discover from configured mainchain client: %v", err)
}
record, ok := service.Resolve("gateway.charon.lthn")
if !ok || len(record.A) != 1 || record.A[0] != "10.10.10.10" {
t.Fatalf("expected gateway A record from configured client, got %#v (ok=%t)", record, ok)
}
if atomic.LoadInt32(&chainCalls) != 1 || atomic.LoadInt32(&hsdTreeRootCalls) != 1 || atomic.LoadInt32(&hsdAliasCalls) != 1 {
t.Fatalf(
"expected chain=1 tree-root=1 name-resource=1, got %d %d %d",
atomic.LoadInt32(&chainCalls),
atomic.LoadInt32(&hsdTreeRootCalls),
atomic.LoadInt32(&hsdAliasCalls),
)
}
}
func TestServiceDiscoverFromMainchainAliasesUsesActionDiscoverer(t *testing.T) {
var treeRootCalls int32
var nameResourceCalls int32
@ -298,8 +373,8 @@ func TestServiceDiscoverFromMainchainAliasesFallsBackToChainClientWhenFallbackCh
server := httptest.NewServer(http.HandlerFunc(func(responseWriter http.ResponseWriter, request *http.Request) {
var payload struct {
Method string `json:"method"`
Params []any `json:"params"`
Method string `json:"method"`
Params []any `json:"params"`
}
if err := json.NewDecoder(request.Body).Decode(&payload); err != nil {
t.Fatalf("unexpected request payload: %v", err)

View file

@ -60,7 +60,7 @@ type ServiceOptions struct {
Records map[string]NameRecords
Discoverer func() (map[string]NameRecords, error)
FallbackDiscoverer func() (map[string]NameRecords, error)
MainchainAliasClient *MainchainAliasClient
MainchainAliasClient *MainchainAliasClient
HSDClient *HSDClient
ChainAliasDiscoverer func(context.Context) ([]string, error)
FallbackChainAliasDiscoverer func(context.Context) ([]string, error)
@ -180,14 +180,19 @@ func (service *Service) DiscoverFromMainchainAliases(ctx context.Context, chainC
return err
}
effectiveChainClient := chainClient
if effectiveChainClient == nil {
effectiveChainClient = service.mainchainAliasClient
}
aliases, err := discoverAliasesWithFallback(
ctx,
func(ctx context.Context) ([]string, error) {
if service.chainAliasDiscoverer != nil {
return service.chainAliasDiscoverer(ctx)
}
if chainClient != nil {
return chainClient.GetAllAliasDetails(ctx)
if effectiveChainClient != nil {
return effectiveChainClient.GetAllAliasDetails(ctx)
}
return nil, nil
},
@ -195,12 +200,12 @@ func (service *Service) DiscoverFromMainchainAliases(ctx context.Context, chainC
if service.fallbackChainAliasDiscoverer != nil {
return service.fallbackChainAliasDiscoverer(ctx)
}
if chainClient != nil && service.chainAliasDiscoverer != nil {
return chainClient.GetAllAliasDetails(ctx)
if effectiveChainClient != nil && service.chainAliasDiscoverer != nil {
return effectiveChainClient.GetAllAliasDetails(ctx)
}
return nil, nil
},
chainClient,
effectiveChainClient,
)
if err != nil {
return err