core/go-dns
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[agent/codex:gpt-5.4-mini] Read docs/RFC.md fully. Find ONE feature described in the sp... #29

Merged
Virgil merged 1 commit from main into dev 2026-04-03 20:51:08 +00:00
Conversation 3 Commits 1 Files changed 2 +38 -4
2 changed files with 38 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
serve.go
View file

@ -184,10 +184,7 @@ func (handler *dnsRequestHandler) ServeDNS(responseWriter dnsprotocol.ResponseWr
})
}
case dnsprotocol.TypeSOA:
if !found {
goto noRecord
}
if normalizeName(name) == handler.service.ZoneApex() {
if normalizeName(name) == handler.service.ZoneApex() && handler.service.ZoneApex() != "" {
reply.Answer = append(reply.Answer, &dnsprotocol.SOA{
Hdr: dnsprotocol.RR_Header{Name: question.Name, Rrtype: dnsprotocol.TypeSOA, Class: dnsprotocol.ClassINET, Ttl: dnsTTL},
Ns: normalizeName("ns."+name) + ".",
@ -198,6 +195,10 @@ func (handler *dnsRequestHandler) ServeDNS(responseWriter dnsprotocol.ResponseWr
Expire: 3600,
Minttl: 300,
})
break
}
if !found {
goto noRecord
}
default:
reply.SetRcode(request, dnsprotocol.RcodeNotImplemented)

33
service_test.go
View file

@ -1000,6 +1000,39 @@ func TestServiceServeAnswersSOAOnlyForZoneApex(t *testing.T) {
}
}
func TestServiceServeAnswersSOAForDerivedZoneApexWithoutExactRecord(t *testing.T) {
service := NewService(ServiceOptions{
Records: map[string]NameRecords{
"gateway.charon.lthn": {
A: []string{"10.10.10.10"},
},
"node.charon.lthn": {
A: []string{"10.10.10.11"},
},
},
})
srv, err := service.Serve("127.0.0.1", 0)
if err != nil {
t.Fatalf("expected server to start: %v", err)
}
defer func() { _ = srv.Close() }()
client := dnsprotocol.Client{}
request := new(dnsprotocol.Msg)
request.SetQuestion("charon.lthn.", dnsprotocol.TypeSOA)
response := exchangeWithRetry(t, client, request, srv.Address())
if response.Rcode != dnsprotocol.RcodeSuccess {
t.Fatalf("expected SOA query for derived apex to succeed, got %d", response.Rcode)
}
if len(response.Answer) != 1 {
t.Fatalf("expected one SOA answer for derived apex, got %d", len(response.Answer))
}
if _, ok := response.Answer[0].(*dnsprotocol.SOA); !ok {
t.Fatalf("expected SOA answer for derived apex, got %#v", response.Answer[0])
}
}
func TestServiceServeReturnsNXDOMAINWhenMissing(t *testing.T) {
service := NewService(ServiceOptions{})