core/go-dns
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[agent/codex:gpt-5.3-codex-spark] Read docs/RFC.md fully. Find ONE feature described in the sp... #92

Merged
Virgil merged 1 commit from main into dev 2026-04-03 23:22:23 +00:00
Conversation 3 Commits 1 Files changed 2 +10 -3
2 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
serve.go
View file

@ -468,6 +468,10 @@ func appendAnyAnswers(reply *dnsprotocol.Msg, questionName string, lookupName st
appendDNSSECResourceRecords(reply, questionName, dnsprotocol.TypeDNSKEY, []string{value})
}
for _, value := range record.DS {
appendDNSSECResourceRecords(reply, questionName, dnsprotocol.TypeDS, []string{value})
}
for _, value := range record.RRSIG {
appendDNSSECResourceRecords(reply, questionName, dnsprotocol.TypeRRSIG, []string{value})
}

9
service_test.go
View file

@ -1817,6 +1817,7 @@ func TestServiceServeAnswersANYWithAllRecordTypes(t *testing.T) {
AAAA: []string{"2600:1f1c:7f0:4f01::1"},
TXT: []string{"v=lthn1 type=gateway"},
NS: []string{"ns.gateway.charon.lthn"},
DS: []string{"60485 8 2 A1B2C3D4E5F60718293A4B5C6D7E8F9012345678"},
},
"node.charon.lthn": {
A: []string{"10.10.10.11"},
@ -1838,7 +1839,7 @@ func TestServiceServeAnswersANYWithAllRecordTypes(t *testing.T) {
t.Fatalf("unexpected ANY rcode: %d", response.Rcode)
}
var sawA, sawAAAA, sawTXT, sawNS, sawSOA bool
var sawA, sawAAAA, sawTXT, sawNS, sawDS, sawSOA bool
for _, answer := range response.Answer {
switch rr := answer.(type) {
case *dnsprotocol.A:
@ -1849,13 +1850,15 @@ func TestServiceServeAnswersANYWithAllRecordTypes(t *testing.T) {
sawTXT = len(rr.Txt) == 1 && rr.Txt[0] == "v=lthn1 type=gateway"
case *dnsprotocol.NS:
sawNS = rr.Ns == "ns.gateway.charon.lthn."
case *dnsprotocol.DS:
sawDS = true
case *dnsprotocol.SOA:
sawSOA = true
}
}
if !sawA || !sawAAAA || !sawTXT || !sawNS {
t.Fatalf("expected ANY answer to include A, AAAA, TXT, and NS records, got %#v", response.Answer)
if !sawA || !sawAAAA || !sawTXT || !sawNS || !sawDS {
t.Fatalf("expected ANY answer to include A, AAAA, TXT, NS, and DS records, got %#v", response.Answer)
}
if sawSOA {
t.Fatalf("expected ANY answer for a non-apex name to omit SOA, got %#v", response.Answer)