2026-02-21 15:22:50 +00:00
|
|
|
package forge
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"context"
|
|
|
|
|
"encoding/json"
|
|
|
|
|
"errors"
|
|
|
|
|
"net/http"
|
|
|
|
|
"net/http/httptest"
|
|
|
|
|
"testing"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_Get(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
if r.Method != http.MethodGet {
|
|
|
|
|
t.Errorf("expected GET, got %s", r.Method)
|
|
|
|
|
}
|
|
|
|
|
if r.Header.Get("Authorization") != "token test-token" {
|
|
|
|
|
t.Errorf("missing auth header")
|
|
|
|
|
}
|
|
|
|
|
if r.URL.Path != "/api/v1/user" {
|
|
|
|
|
t.Errorf("wrong path: %s", r.URL.Path)
|
|
|
|
|
}
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"login": "virgil"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
var out map[string]string
|
|
|
|
|
err := c.Get(context.Background(), "/api/v1/user", &out)
|
|
|
|
|
if err != nil {
|
|
|
|
|
t.Fatal(err)
|
|
|
|
|
}
|
|
|
|
|
if out["login"] != "virgil" {
|
|
|
|
|
t.Errorf("got login=%q", out["login"])
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_Post(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
if r.Method != http.MethodPost {
|
|
|
|
|
t.Errorf("expected POST, got %s", r.Method)
|
|
|
|
|
}
|
|
|
|
|
var body map[string]string
|
|
|
|
|
json.NewDecoder(r.Body).Decode(&body)
|
|
|
|
|
if body["name"] != "test-repo" {
|
|
|
|
|
t.Errorf("wrong body: %v", body)
|
|
|
|
|
}
|
|
|
|
|
w.WriteHeader(http.StatusCreated)
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]any{"id": 1, "name": "test-repo"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
body := map[string]string{"name": "test-repo"}
|
|
|
|
|
var out map[string]any
|
|
|
|
|
err := c.Post(context.Background(), "/api/v1/orgs/core/repos", body, &out)
|
|
|
|
|
if err != nil {
|
|
|
|
|
t.Fatal(err)
|
|
|
|
|
}
|
|
|
|
|
if out["name"] != "test-repo" {
|
|
|
|
|
t.Errorf("got name=%v", out["name"])
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_Delete(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
if r.Method != http.MethodDelete {
|
|
|
|
|
t.Errorf("expected DELETE, got %s", r.Method)
|
|
|
|
|
}
|
|
|
|
|
w.WriteHeader(http.StatusNoContent)
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
err := c.Delete(context.Background(), "/api/v1/repos/core/test")
|
|
|
|
|
if err != nil {
|
|
|
|
|
t.Fatal(err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Bad_ServerError(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
w.WriteHeader(http.StatusInternalServerError)
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"message": "internal error"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
err := c.Get(context.Background(), "/api/v1/user", nil)
|
|
|
|
|
if err == nil {
|
|
|
|
|
t.Fatal("expected error")
|
|
|
|
|
}
|
|
|
|
|
var apiErr *APIError
|
|
|
|
|
if !errors.As(err, &apiErr) {
|
|
|
|
|
t.Fatalf("expected APIError, got %T", err)
|
|
|
|
|
}
|
|
|
|
|
if apiErr.StatusCode != 500 {
|
|
|
|
|
t.Errorf("got status=%d", apiErr.StatusCode)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Bad_NotFound(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
w.WriteHeader(http.StatusNotFound)
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"message": "not found"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
err := c.Get(context.Background(), "/api/v1/repos/x/y", nil)
|
|
|
|
|
if !IsNotFound(err) {
|
|
|
|
|
t.Fatalf("expected not found, got %v", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_ContextCancellation(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
<-r.Context().Done()
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "test-token")
|
|
|
|
|
ctx, cancel := context.WithCancel(context.Background())
|
|
|
|
|
cancel() // cancel immediately
|
|
|
|
|
err := c.Get(ctx, "/api/v1/user", nil)
|
|
|
|
|
if err == nil {
|
|
|
|
|
t.Fatal("expected error from cancelled context")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_Options(t *testing.T) {
|
|
|
|
|
c := NewClient("https://forge.lthn.ai", "tok",
|
|
|
|
|
WithUserAgent("go-forge/1.0"),
|
|
|
|
|
)
|
|
|
|
|
if c.userAgent != "go-forge/1.0" {
|
|
|
|
|
t.Errorf("got user agent=%q", c.userAgent)
|
|
|
|
|
}
|
|
|
|
|
}
|
fix(dx): update CLAUDE.md and add tests for untested critical paths
- Fix CLAUDE.md: "zero dependencies" → documents go-io/go-log deps
- Add coding standards for coreerr.E() and go-io usage
- Add tests for APIError.Error(), IsConflict, IsForbidden, WithHTTPClient,
RateLimit, Forge.Client(), Resource.Iter() (happy, error, early-break)
- Coverage: 64.5% → 66.8% (+2.3%)
- No fmt.Errorf, errors.New, or os.ReadFile/WriteFile violations found
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-17 08:11:30 +00:00
|
|
|
|
|
|
|
|
func TestClient_Good_WithHTTPClient(t *testing.T) {
|
|
|
|
|
custom := &http.Client{}
|
|
|
|
|
c := NewClient("https://forge.lthn.ai", "tok", WithHTTPClient(custom))
|
|
|
|
|
if c.httpClient != custom {
|
|
|
|
|
t.Error("expected custom HTTP client to be set")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestAPIError_Good_Error(t *testing.T) {
|
|
|
|
|
e := &APIError{StatusCode: 404, Message: "not found", URL: "/api/v1/repos/x/y"}
|
|
|
|
|
got := e.Error()
|
|
|
|
|
want := "forge: /api/v1/repos/x/y 404: not found"
|
|
|
|
|
if got != want {
|
|
|
|
|
t.Errorf("got %q, want %q", got, want)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestIsConflict_Good(t *testing.T) {
|
|
|
|
|
err := &APIError{StatusCode: http.StatusConflict, Message: "conflict", URL: "/test"}
|
|
|
|
|
if !IsConflict(err) {
|
|
|
|
|
t.Error("expected IsConflict to return true for 409")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestIsConflict_Bad_NotConflict(t *testing.T) {
|
|
|
|
|
err := &APIError{StatusCode: http.StatusNotFound, Message: "not found", URL: "/test"}
|
|
|
|
|
if IsConflict(err) {
|
|
|
|
|
t.Error("expected IsConflict to return false for 404")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestIsForbidden_Bad_NotForbidden(t *testing.T) {
|
|
|
|
|
err := &APIError{StatusCode: http.StatusNotFound, Message: "not found", URL: "/test"}
|
|
|
|
|
if IsForbidden(err) {
|
|
|
|
|
t.Error("expected IsForbidden to return false for 404")
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Good_RateLimit(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
w.Header().Set("X-RateLimit-Limit", "100")
|
|
|
|
|
w.Header().Set("X-RateLimit-Remaining", "99")
|
|
|
|
|
w.Header().Set("X-RateLimit-Reset", "1700000000")
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"login": "test"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "tok")
|
|
|
|
|
var out map[string]string
|
|
|
|
|
if err := c.Get(context.Background(), "/api/v1/user", &out); err != nil {
|
|
|
|
|
t.Fatal(err)
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
rl := c.RateLimit()
|
|
|
|
|
if rl.Limit != 100 {
|
|
|
|
|
t.Errorf("got limit=%d, want 100", rl.Limit)
|
|
|
|
|
}
|
|
|
|
|
if rl.Remaining != 99 {
|
|
|
|
|
t.Errorf("got remaining=%d, want 99", rl.Remaining)
|
|
|
|
|
}
|
|
|
|
|
if rl.Reset != 1700000000 {
|
|
|
|
|
t.Errorf("got reset=%d, want 1700000000", rl.Reset)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Bad_Forbidden(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
w.WriteHeader(http.StatusForbidden)
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"message": "forbidden"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "tok")
|
|
|
|
|
err := c.Get(context.Background(), "/api/v1/admin", nil)
|
|
|
|
|
if !IsForbidden(err) {
|
|
|
|
|
t.Fatalf("expected forbidden, got %v", err)
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func TestClient_Bad_Conflict(t *testing.T) {
|
|
|
|
|
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
|
|
|
w.WriteHeader(http.StatusConflict)
|
|
|
|
|
json.NewEncoder(w).Encode(map[string]string{"message": "already exists"})
|
|
|
|
|
}))
|
|
|
|
|
defer srv.Close()
|
|
|
|
|
|
|
|
|
|
c := NewClient(srv.URL, "tok")
|
|
|
|
|
err := c.Post(context.Background(), "/api/v1/repos", map[string]string{"name": "dup"}, nil)
|
|
|
|
|
if !IsConflict(err) {
|
|
|
|
|
t.Fatalf("expected conflict, got %v", err)
|
|
|
|
|
}
|
|
|
|
|
}
|