core/go-forge
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

chore(forge): centralise default pagination limit
Some checks failed
Test / test (push) Waiting to run
Details
Security Scan / security (push) Has been cancelled
Details

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Virgil 2026-04-02 06:45:54 +00:00
parent 55616b5e1e
commit 870d143f78
2 changed files with 8 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
notifications.go
View file

@ -187,7 +187,7 @@ func (s *NotificationService) listAll(ctx context.Context, path string, filters
page := 1
for {
result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: 50}, filters...)
result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: defaultPageLimit}, filters...)
if err != nil {
return nil, err
}
@ -205,7 +205,7 @@ func (s *NotificationService) listIter(ctx context.Context, path string, filters
return func(yield func(types.NotificationThread, error) bool) {
page := 1
for {
result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: 50}, filters...)
result, err := s.listPage(ctx, path, ListOptions{Page: page, Limit: defaultPageLimit}, filters...)
if err != nil {
yield(*new(types.NotificationThread), err)
return
@ -228,7 +228,7 @@ func (s *NotificationService) listPage(ctx context.Context, path string, opts Li
opts.Page = 1
}
if opts.Limit < 1 {
opts.Limit = 50
opts.Limit = defaultPageLimit
}
u, err := url.Parse(path)

8
pagination.go
View file

@ -10,6 +10,8 @@ import (
core "dappco.re/go/core"
)
const defaultPageLimit = 50
// ListOptions controls pagination.
//
// Usage:
@ -54,7 +56,7 @@ func ListPage[T any](ctx context.Context, c *Client, path string, query map[stri
opts.Page = 1
}
if opts.Limit < 1 {
opts.Limit = 50
opts.Limit = defaultPageLimit
}
u, err := url.Parse(path)
@ -100,7 +102,7 @@ func ListAll[T any](ctx context.Context, c *Client, path string, query map[strin
page := 1
for {
result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: 50})
result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit})
if err != nil {
return nil, err
}
@ -125,7 +127,7 @@ func ListIter[T any](ctx context.Context, c *Client, path string, query map[stri
return func(yield func(T, error) bool) {
page := 1
for {
result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: 50})
result, err := ListPage[T](ctx, c, path, query, ListOptions{Page: page, Limit: defaultPageLimit})
if err != nil {
yield(*new(T), err)
return