core/go-i18n
8
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

Fix CodeRabbit findings #11

Merged
Snider merged 1 commit from agent/fix-coderabbit-findings--verify-each-aga into dev 2026-03-24 11:33:20 +00:00
Conversation 0 Commits 1 Files changed 3 +31 -6
Virgil commented 2026-03-24 11:30:34 +00:00
Member
Copy link
No description provided.
Virgil added 1 commit 2026-03-24 11:30:34 +00:00
fix(coderabbit): address review findings
Some checks failed
Security Scan / security (pull_request) Successful in 8s
Details
Test / test (pull_request) Failing after 27s
Details
1d6d891932 
1. core_service.go: Return error when SetLanguage fails instead of
   silently discarding it.
2. grammar.go/service.go: Add MergeGrammarData() and use it in AddLoader
   and loadJSON so multiple loaders merge grammar entries instead of
   replacing the entire struct per language.
3. service.go: Document that package-level AddLoader is superseded when
   NewCoreService replaces the default — by design, not a bug.
4. service.go: Use CompareAndSwap in Init() to prevent TOCTOU race where
   a concurrent SetDefault could be overwritten.

Co-Authored-By: Virgil <virgil@lethean.io>
Snider merged commit 6bf0515ed8 into dev 2026-03-24 11:33:20 +00:00
Snider deleted branch agent/fix-coderabbit-findings--verify-each-aga 2026-03-24 11:33:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review

   
needs-review
  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
needs-review
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/go-i18n#11
No description provided.
Delete branch "agent/fix-coderabbit-findings--verify-each-aga"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?