core/go-i18n
8
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/i18n/RFC.md fully. Find ONE feature... #119

Merged
Virgil merged 1 commit from agent/read---spec-code-core-go-i18n-rfc-md-ful into dev 2026-04-02 04:52:51 +00:00
Conversation 1 Commits 1 Files changed 2 +25 -8
2 changed files with 25 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
service.go
View file

@ -403,17 +403,11 @@ func (s *Service) resolveWithFallback(messageID string, data any) string {
parts := core.Split(messageID, ".")
verb := parts[len(parts)-1]
commonKey := "common.action." + verb
if text := s.tryResolve(s.currentLang, commonKey, data); text != "" {
return text
}
if text := s.tryResolve(s.fallbackLang, commonKey, data); text != "" {
if text := s.resolveDirect(commonKey, data); text != "" {
return text
}
commonKey = "common." + verb
if text := s.tryResolve(s.currentLang, commonKey, data); text != "" {
return text
}
if text := s.tryResolve(s.fallbackLang, commonKey, data); text != "" {
if text := s.resolveDirect(commonKey, data); text != "" {
return text
}
}

23
service_test.go
View file

@ -296,6 +296,29 @@ func TestServiceMessageFallbackUsesBaseLanguageTagBeforeConfiguredFallback(t *te
}
}
func TestServiceCommonFallbackUsesBaseLanguageTagBeforeConfiguredFallback(t *testing.T) {
svc, err := NewWithLoader(messageBaseFallbackLoader{})
if err != nil {
t.Fatalf("NewWithLoader() failed: %v", err)
}
svc.AddMessages("en", map[string]string{
"common.action.status": "Common status",
})
svc.AddMessages("fr", map[string]string{
"common.action.status": "Statut commun",
})
if err := svc.SetLanguage("en-GB"); err != nil {
t.Fatalf("SetLanguage(en-GB) failed: %v", err)
}
svc.SetFallback("fr")
if got := svc.T("missing.status"); got != "Common status" {
t.Fatalf("T(missing.status) = %q, want %q", got, "Common status")
}
}
func TestServiceDebug(t *testing.T) {
svc, err := New()
if err != nil {