[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/i18n/RFC.md fully. Find features de... #136

Merged
Virgil merged 1 commit from agent/read---spec-code-core-go-i18n-rfc-md-ful into dev 2026-04-02 06:22:22 +00:00
2 changed files with 21 additions and 1 deletions

View file

@ -148,5 +148,9 @@ func normalizeLanguageTag(lang string) string {
if lang == "" {
return ""
}
return core.Replace(lang, "_", "-")
lang = core.Replace(lang, "_", "-")
if tag, err := language.Parse(lang); err == nil {
return tag.String()
}
return lang
}

View file

@ -386,6 +386,22 @@ func TestServiceFallbackNormalisesLanguageTag(t *testing.T) {
}
}
func TestServiceFallbackCanonicalisesLanguageTagCase(t *testing.T) {
svc, err := New(WithFallback("FR_ca"))
if err != nil {
t.Fatalf("New() failed: %v", err)
}
if got, want := svc.Fallback(), "fr-CA"; got != want {
t.Fatalf("WithFallback(FR_ca) = %q, want %q", got, want)
}
svc.SetFallback("EN_us")
if got, want := svc.Fallback(), "en-US"; got != want {
t.Fatalf("SetFallback(EN_us) = %q, want %q", got, want)
}
}
func TestServiceMessageFallbackUsesBaseLanguageTagBeforeConfiguredFallback(t *testing.T) {
svc, err := NewWithLoader(messageBaseFallbackLoader{})
if err != nil {