[agent/claude:opus] DX audit and fix. 1) Review CLAUDE.md — update any outdate... #2

Merged

Virgil merged 1 commit from agent/dx-audit-and-fix--1--review-claude-md into main

2026-03-17 08:03:28 +00:00

Virgil commented

2026-03-17 07:51:50 +00:00

Member

Task

DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run go test -cover ./... — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes.

Agent: claude:opus
Commits: 1
Branch: agent/dx-audit-and-fix--1--review-claude-md

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run `go test -cover ./...` — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/dx-audit-and-fix--1--review-claude-md` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-17 07:51:50 +00:00

fix(dx): migrate error handling to log.E(), fix build, add tests

Security Scan / security (pull_request) Successful in 7s

Details

Test / test (pull_request) Successful in 1m24s

Details

aa5d739f9d

- Replace all fmt.Errorf/errors.New with log.E() from go-log
- Fix core_service.go build error (c.Locales() does not exist on Core)
- Add tests for Service.AddLoader, LoadFS, LanguagesErr, flatten, IsRTL
- Document error handling convention in CLAUDE.md
- Coverage: 85.2% root, 91.0% reversal (up from 83.1%)

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-17 07:51:51 +00:00

Author

Member

Verification Failed

# ./...
pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies
FAIL	./... [setup failed]
FAIL

Exit code: 1

PR will not be auto-merged.

## Verification Failed ``` # ./... pattern ./...: directory prefix . does not contain modules listed in go.work or their selected dependencies FAIL ./... [setup failed] FAIL ``` **Exit code:** 1 PR will not be auto-merged.