[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/i18n/RFC.md fully. Find ONE feature... #59

Merged
Virgil merged 1 commit from agent/read---spec-code-core-go-i18n-rfc-md-ful into dev 2026-04-02 00:13:20 +00:00
2 changed files with 122 additions and 0 deletions

View file

@ -709,6 +709,71 @@ func ArticlePhrase(word string) string {
return article + " " + word
}
// DefiniteArticle returns the language-specific definite article for a word.
// For languages such as French, this respects gendered articles, plural forms,
// and elision rules when grammar data is available.
func DefiniteArticle(word string) string {
if word == "" {
return ""
}
trimmed := core.Trim(word)
lower := core.Lower(trimmed)
if article, ok := definiteArticleForCurrentLanguage(lower, trimmed); ok {
return article
}
lang := currentLangForGrammar()
data := GetGrammarData(lang)
if data != nil && data.Articles.Definite != "" {
return data.Articles.Definite
}
return "the"
}
// DefinitePhrase prefixes a noun phrase with the correct definite article.
func DefinitePhrase(word string) string {
if word == "" {
return ""
}
lang := currentLangForGrammar()
word = renderWord(lang, word)
article := DefiniteArticle(word)
if article == "" {
return ""
}
if strings.HasSuffix(article, "'") {
return article + word
}
return article + " " + word
}
func definiteArticleForCurrentLanguage(lowerWord, originalWord string) (string, bool) {
lang := currentLangForGrammar()
data := GetGrammarData(lang)
if data == nil {
return "", false
}
if article, ok := articleByGender(data, lowerWord, originalWord, lang); ok {
return article, true
}
if article, ok := definiteArticleFromGrammarForms(data, lowerWord, originalWord, lang); ok {
return article, true
}
return "", false
}
func definiteArticleFromGrammarForms(data *GrammarData, lowerWord, originalWord, lang string) (string, bool) {
if data == nil || data.Articles.Definite == "" {
return "", false
}
if isFrenchLanguage(lang) {
if isKnownPluralNoun(data, lowerWord) || looksLikeFrenchPlural(originalWord) {
return "les", true
}
return maybeElideArticle(data.Articles.Definite, originalWord, lang), true
}
return data.Articles.Definite, true
}
// TemplateFuncs returns the template.FuncMap with all grammar functions.
func TemplateFuncs() template.FuncMap {
return template.FuncMap{
@ -720,6 +785,7 @@ func TemplateFuncs() template.FuncMap {
"plural": Pluralize,
"pluralForm": PluralForm,
"article": ArticlePhrase,
"definite": DefinitePhrase,
"quote": Quote,
"label": Label,
"progress": Progress,

View file

@ -590,6 +590,62 @@ func TestArticlePhraseFrenchLocale(t *testing.T) {
}
}
func TestDefiniteArticle(t *testing.T) {
tests := []struct {
word string
want string
}{
{"file", "the"},
{"error", "the"},
{"", ""},
}
for _, tt := range tests {
t.Run(tt.word, func(t *testing.T) {
got := DefiniteArticle(tt.word)
if got != tt.want {
t.Errorf("DefiniteArticle(%q) = %q, want %q", tt.word, got, tt.want)
}
})
}
}
func TestDefinitePhraseFrenchLocale(t *testing.T) {
prev := Default()
svc, err := New()
if err != nil {
t.Fatalf("New() failed: %v", err)
}
SetDefault(svc)
t.Cleanup(func() {
SetDefault(prev)
})
if err := SetLanguage("fr"); err != nil {
t.Fatalf("SetLanguage(fr) failed: %v", err)
}
tests := []struct {
word string
want string
}{
{"branche", "la branche"},
{"branches", "les branches"},
{"amis", "les amis"},
{"enfant", "l'enfant"},
{"fichier", "le fichier"},
}
for _, tt := range tests {
t.Run(tt.word, func(t *testing.T) {
got := DefinitePhrase(tt.word)
if got != tt.want {
t.Errorf("DefinitePhrase(%q) = %q, want %q", tt.word, got, tt.want)
}
})
}
}
func TestLabel(t *testing.T) {
svc, err := New()
if err != nil {