[agent/codex:gpt-5.4-mini] Read the JS reference source at docs/js-covenants/ and docs/... #1

Open
Virgil wants to merge 15 commits from agent/read-the-js-reference-source-at-docs-js into dev
Member

Task

Read the JS reference source at docs/js-covenants/ and docs/js-primitives/ fully. Read the existing Go code at pkg/primitives/ and pkg/covenant/. Find ONE feature implemented in the JS that is NOT in the Go code. Implement it using Core primitives. No banned imports (os, fmt, log, errors, strings, path/filepath, encoding/json). Use core.E() for errors. UK English in comments. Commit when done.

Agent: codex:gpt-5.4-mini
Commits: 1
Branch: agent/read-the-js-reference-source-at-docs-js


Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Read the JS reference source at docs/js-covenants/ and docs/js-primitives/ fully. Read the existing Go code at pkg/primitives/ and pkg/covenant/. Find ONE feature implemented in the JS that is NOT in the Go code. Implement it using Core primitives. No banned imports (os, fmt, log, errors, strings, path/filepath, encoding/json). Use core.E() for errors. UK English in comments. Commit when done. **Agent:** codex:gpt-5.4-mini **Commits:** 1 **Branch:** `agent/read-the-js-reference-source-at-docs-js` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
Author
Member

Verification Failed

Command: go test ./...

# dappco.re/go/lns
FAIL	dappco.re/go/lns [setup failed]
lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add:
	go get dappco.re/go/lns
FAIL	dappco.re/go/lns/pkg/dns [setup failed]
# dappco.re/go/lns/pkg/dns
lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add:
	go get dappco.re/go/lns
?   	dappco.re/go/lns/pkg/covenant	[no test files]
ok  	dappco.re/go/lns/pkg/primitives	0.173s
FAIL

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` # dappco.re/go/lns FAIL dappco.re/go/lns [setup failed] lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add: go get dappco.re/go/lns FAIL dappco.re/go/lns/pkg/dns [setup failed] # dappco.re/go/lns/pkg/dns lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add: go get dappco.re/go/lns ? dappco.re/go/lns/pkg/covenant [no test files] ok dappco.re/go/lns/pkg/primitives 0.173s FAIL ``` **Exit code:** 1
Author
Member

Verification Failed

Command: go test ./...

# dappco.re/go/lns
FAIL	dappco.re/go/lns [setup failed]
lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add:
	go get dappco.re/go/lns
# dappco.re/go/lns/pkg/dns
lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add:
	go get dappco.re/go/lns
FAIL	dappco.re/go/lns/pkg/dns [setup failed]
?   	dappco.re/go/lns/pkg/covenant	[no test files]
ok  	dappco.re/go/lns/pkg/primitives	0.175s
FAIL

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` # dappco.re/go/lns FAIL dappco.re/go/lns [setup failed] lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add: go get dappco.re/go/lns # dappco.re/go/lns/pkg/dns lns.go:15:8: missing go.sum entry for module providing package dappco.re/go/core (imported by dappco.re/go/lns); to add: go get dappco.re/go/lns FAIL dappco.re/go/lns/pkg/dns [setup failed] ? dappco.re/go/lns/pkg/covenant [no test files] ok dappco.re/go/lns/pkg/primitives 0.175s FAIL ``` **Exit code:** 1
Author
Member

Needs Review

Tests failed after rebase. Auto-merge gave up after retry.

Labelled needs-review for human attention.

## Needs Review Tests failed after rebase. Auto-merge gave up after retry. Labelled `needs-review` for human attention.
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Add name-suffixed ResolveName/VerifyName aliases at both the DNS service and LNS service layers, and cover them with tests.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Add conservative coinbase-linked covenant verification for linked outputs, including witness cardinality and claim height checks.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Reduce alias indirection for catalog accessors and DNS binary helpers so the public API routes through the shared default paths.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Hash catalog fallbacks directly so canonical .lthn lookups still work for labels that contain dots.

Add a regression test that covers raw dotted labels and canonical dotted suffix lookups.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Add Service LookupCatalogName and GetLookupCatalogName wrappers and tests to ensure dotted-label catalog resolution remains preserved at service scope.

Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
No additional features were found between the local implementation and accessible reference behavior. README/spec paths under ~/spec/ were inaccessible in this environment, so no spec-driven deltas were applied.

Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-authored-by: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
Co-Authored-By: Virgil <virgil@lethean.io>
This pull request has changes conflicting with the target branch.
  • lns.go
  • lns_test.go
  • pkg/covenant/blind_test.go
  • pkg/covenant/covenant_test.go
  • pkg/covenant/locked_lookup_test.go
  • pkg/covenant/name_test.go
  • pkg/covenant/rules_extra_test.go
  • pkg/dns/common.go
  • pkg/dns/common_test.go
  • pkg/dns/nsec.go
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin agent/read-the-js-reference-source-at-docs-js:agent/read-the-js-reference-source-at-docs-js
git switch agent/read-the-js-reference-source-at-docs-js

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff agent/read-the-js-reference-source-at-docs-js
git switch agent/read-the-js-reference-source-at-docs-js
git rebase dev
git switch dev
git merge --ff-only agent/read-the-js-reference-source-at-docs-js
git switch agent/read-the-js-reference-source-at-docs-js
git rebase dev
git switch dev
git merge --no-ff agent/read-the-js-reference-source-at-docs-js
git switch dev
git merge --squash agent/read-the-js-reference-source-at-docs-js
git switch dev
git merge --ff-only agent/read-the-js-reference-source-at-docs-js
git switch dev
git merge agent/read-the-js-reference-source-at-docs-js
git push origin dev
Sign in to join this conversation.
No description provided.