core/go-mlx
8
0
Fork 0
Code Issues 5 Pull requests Projects Releases Packages Wiki Activity Actions 1

[agent/claude:opus] Fix CodeRabbit findings. Verify each against current code, f... #4

Closed
Virgil wants to merge 0 commits from agent/fix-coderabbit-findings--verify-each-aga into dev
pull from: agent/fix-coderabbit-findings--verify-each-aga
merge into: core:dev
Conversation 3 Commits - Files changed - +6 -3
Virgil commented 2026-03-17 16:23:28 +00:00
Member
Copy link

Task

Fix CodeRabbit findings. Verify each against current code, fix ONLY if valid. Run tests. Commit: fix(coderabbit): address review findings

IMPORTANT: Do NOT change function signatures in dependency packages.

  1. internal/metal/metal.go:81-82 — Fallback error discards return-code variable rc. Include rc in the error message.
  2. internal/metal/batch.go — check inline findings.

Agent: claude:opus
Commits: 1
Branch: agent/fix-coderabbit-findings--verify-each-aga

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Fix CodeRabbit findings. Verify each against current code, fix ONLY if valid. Run tests. Commit: fix(coderabbit): address review findings IMPORTANT: Do NOT change function signatures in dependency packages. 1. internal/metal/metal.go:81-82 — Fallback error discards return-code variable rc. Include rc in the error message. 2. internal/metal/batch.go — check inline findings. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/fix-coderabbit-findings--verify-each-aga` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
fix(coderabbit): address review findings
All checks were successful
Security Scan / security (pull_request) Successful in 9s
Details
Test / Vet & Build (pull_request) Successful in 32s
Details
15d6dce956 
Include rc return code in fallback error messages for Eval/EvalAsync.
Fix resource leaks in BatchGenerate: free tokens/mask after prefill,
free final logits after decode loop (previously leaked when maxTokens
exhausted without all sequences finishing).

Co-Authored-By: Virgil <virgil@lethean.io>
Virgil commented 2026-03-17 16:23:30 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-mlx_test [forge.lthn.ai/core/go-mlx.test]
./mlx_test.go:455:17: assignment mismatch: 2 variables but inference.Discover returns 1 value
FAIL	forge.lthn.ai/core/go-mlx [build failed]
# forge.lthn.ai/core/go-mlx/internal/metal.test
/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1
/usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b139/metal.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5...

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-mlx_test [forge.lthn.ai/core/go-mlx.test] ./mlx_test.go:455:17: assignment mismatch: 2 variables but inference.Discover returns 1 value FAIL forge.lthn.ai/core/go-mlx [build failed] # forge.lthn.ai/core/go-mlx/internal/metal.test /opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1 /usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b139/metal.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2714537575/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5... ``` **Exit code:** 1
Virgil commented 2026-03-17 16:23:31 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-mlx_test [forge.lthn.ai/core/go-mlx.test]
./mlx_test.go:455:17: assignment mismatch: 2 variables but inference.Discover returns 1 value
FAIL	forge.lthn.ai/core/go-mlx [build failed]
# forge.lthn.ai/core/go-mlx/internal/metal.test
/opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1
/usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b139/metal.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5...

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-mlx_test [forge.lthn.ai/core/go-mlx.test] ./mlx_test.go:455:17: assignment mismatch: 2 variables but inference.Discover returns 1 value FAIL forge.lthn.ai/core/go-mlx [build failed] # forge.lthn.ai/core/go-mlx/internal/metal.test /opt/homebrew/opt/go/libexec/pkg/tool/darwin_arm64/link: running c++ failed: exit status 1 /usr/bin/c++ -arch arm64 -Wl,-S -Wl,-x -o $WORK/b139/metal.test -Qunused-arguments /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/go.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000000.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000001.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000002.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000003.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000004.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000005.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000006.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000007.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000008.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000009.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000010.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000011.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000012.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000013.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000014.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000015.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000016.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000017.o /var/folders/k6/c05lqf4j1nz248lbk_n5wbj80000gn/T/go-link-2638539163/000018.o /var/folders/k6/c05lqf4j1nz248lbk_n5... ``` **Exit code:** 1
Virgil commented 2026-03-17 16:23:32 +00:00
Author
Member
Copy link

Needs Review

Tests failed after rebase. Auto-merge gave up after retry.

Labelled needs-review for human attention.

## Needs Review Tests failed after rebase. Auto-merge gave up after retry. Labelled `needs-review` for human attention.
Virgil changed target branch from main to dev 2026-03-24 11:12:17 +00:00
Virgil closed this pull request 2026-03-24 11:19:13 +00:00
All checks were successful
Security Scan / security (pull_request) Successful in 9s
Details
Test / Vet & Build (pull_request) Successful in 32s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review
  
athena
Assign to Athena AI agent (M3 Ultra)

  
athena-gemini
Dispatch to Gemini CLI on M3 Ultra

  
audit
Code audit task

  
clotho
Assign to Clotho AI agent for processing

  
clotho-gemini
Dispatch to Gemini CLI on darbs (AU)

  
codex
Dispatch to Codex CLI on gateway for analysis

  
darbs-claude
Dispatch to Claude on darbs (AU)

  
security
Security review task

  
wiki
Documentation/wiki update

No labels
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
core/go-mlx!4
No description provided.