core/go-p2p
8
0
Fork 0
Code Issues 4 Pull requests 1 Projects Releases Packages Wiki Activity Actions

chore: Go 1.26 modernization #2

Merged
Charon merged 4 commits from chore/go-1.26-modernization into main 2026-02-24 18:01:44 +00:00
Conversation 0 Commits 4 Files changed 11 +58 -45
Charon commented 2026-02-24 16:42:57 +00:00
Member
Copy link

Modernize Go 1.23-era patterns to Go 1.26 idioms.

  • fmt.Errorf(static) → errors.New (26 occurrences)
  • Extract repeated sentinel errors to package-level vars:
    • ErrIdentityNotInitialized (8 uses)
    • ErrMinerManagerNotConfigured (3 uses)
  • Manual min/max → min()/max() builtins (1 occurrence)
  • Sorted map keys → slices.Sorted(maps.Keys()) (1 occurrence)

Sentinel extraction enables errors.Is() matching. All changes pass go build and go vet. No test files modified.

Modernize Go 1.23-era patterns to Go 1.26 idioms. - `fmt.Errorf(static)` → `errors.New` (26 occurrences) - Extract repeated sentinel errors to package-level vars: - `ErrIdentityNotInitialized` (8 uses) - `ErrMinerManagerNotConfigured` (3 uses) - Manual min/max → `min()`/`max()` builtins (1 occurrence) - Sorted map keys → `slices.Sorted(maps.Keys())` (1 occurrence) Sentinel extraction enables `errors.Is()` matching. All changes pass `go build` and `go vet`. No test files modified.
Charon added 4 commits 2026-02-24 16:42:57 +00:00 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore: use slices.Sorted(maps.Keys()) for ordered iteration
All checks were successful
Security Scan / security (pull_request) Successful in 14s
Details
Test / test (pull_request) Successful in 2m5s
Details
030834905e 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Charon merged commit 8f049dd29c into main 2026-02-24 18:01:44 +00:00
Charon deleted branch chore/go-1.26-modernization 2026-02-24 18:01:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review
  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
needs-review
needs-review
needs-review
needs-review
needs-review
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/go-p2p#2
No description provided.
Delete branch "chore/go-1.26-modernization"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?