[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/p2p/RFC.md fully. Find ONE feature ... #23

Open
Virgil wants to merge 69 commits from agent/read---spec-code-core-go-p2p-rfc-md-full into dev

69 commits

Author SHA1 Message Date
Virgil
8b33ab2c2b fix(transport): release connection state on close
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m41s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-04-01 05:22:27 +00:00
Snider
a98acdfb8e Merge /Users/snider/Code/.core/workspace/core/go-p2p/dev/repo into dev
Some checks failed
Security Scan / security (push) Successful in 9s
Test / test (push) Failing after 55s
2026-03-31 18:47:19 +01:00
Virgil
fb9c918857 refactor(node): align transport naming with AX
Some checks failed
Security Scan / security (push) Successful in 9s
Test / test (push) Failing after 41s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
9c5f3d0bd3 refactor(node): trim redundant AX comments
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
194fe707de refactor(node): align AX comments and peer copy semantics
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
e3b66f7e8c refactor(node): align remaining AX naming and examples
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
a1d9b08baf refactor(node): tighten AX comments across public APIs
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
96d83a4b21 refactor(node): align AX naming across transport and protocol helpers
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
de7e866acf refactor(p2p): align AX comments and harden UEPS parsing
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
314c8ed470 fix(transport): serialise graceful websocket close
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
9523bd1e9a refactor(node): align AX comments across public APIs
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
0d9f03031c refactor(logging): remove stale alias wording
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
9a302ce7b5 refactor(node): remove AX compatibility aliases
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
cd7535fc80 refactor(logging): prefer get-style logger accessors
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 15:39:28 +01:00
Virgil
2eecb6cfc6 refactor(node): align transport naming with AX
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 14:32:55 +00:00
Virgil
849a716360 refactor(node): trim redundant AX comments
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 14:25:37 +00:00
Virgil
e5953e4b86 refactor(node): align AX comments and peer copy semantics
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 14:19:03 +00:00
Virgil
1ee54add39 refactor(node): align remaining AX naming and examples
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 14:11:17 +00:00
Virgil
3733e61962 refactor(node): tighten AX comments across public APIs
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 14:04:41 +00:00
Virgil
723f71143e refactor(node): align AX naming across transport and protocol helpers
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:56:56 +00:00
Virgil
643b93da01 refactor(p2p): align AX comments and harden UEPS parsing
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:48:17 +00:00
Virgil
4f47855052 fix(transport): serialise graceful websocket close
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:42:04 +00:00
Virgil
8fc3be03a6 refactor(node): align AX comments across public APIs
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:36:45 +00:00
Virgil
b5c7516224 refactor(logging): remove stale alias wording
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:29:51 +00:00
Virgil
711a43aa3f refactor(node): remove AX compatibility aliases
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:26:00 +00:00
Virgil
c2e60c6ece refactor(logging): prefer get-style logger accessors
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:20:17 +00:00
Virgil
a5be0146d3 refactor(node): align AX branch state
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:14:14 +00:00
5ed1a67a2e Merge pull request '[agent/codex:gpt-5.4-mini] Update the code against the AX design principles in ~/spec/r...' (#22) from agent/update-the-code-against-the-ax-design-pr into dev
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m38s
2026-03-31 13:12:14 +00:00
Virgil
cc0715785d fix(node): restore AX compatibility aliases
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 13:11:24 +00:00
Snider
aa182f5284 Revert "feat(compat): implement spec-described aliases across all packages"
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m20s
This reverts commit 85de30a528.
2026-03-31 12:26:23 +01:00
Snider
85de30a528 feat(compat): implement spec-described aliases across all packages
Add compatibility aliases documented in specs but missing from code:

- node: NewNodeManagerWithPaths, NewPeerRegistryWithPath (deprecated
  constructor aliases), RegisterWithTransport (deprecated method alias),
  ConnectedPeers (count alias), GetLogsPayload (type alias)
- levin: Short-form Value constructors (Uint64Val, StringVal, ObjectVal,
  etc.) matching spec naming
- logging: WithComponent, GetLevel, GetGlobal (deprecated method aliases)
- ueps: TagCurrentLay, TagTargetLay (short-form tag constant aliases)

All aliases delegate to the canonical AX-compliant names. Tests cover
every alias with round-trip verification where applicable.

Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 12:25:22 +01:00
Snider
5ed4451555 feat(ax): AX compliance sweep — comments as usage examples, remove linter-injected aliases
All checks were successful
Security Scan / security (push) Successful in 8s
Test / test (push) Successful in 1m31s
Applied AX principles 1, 2, and 9 across the node, dispatcher, transport, peer,
worker, bundle, and logging packages:

- Added usage-example comments to all public methods missing them (AX-2):
  dispatcher.RegisterHandler, Handlers; peer.AddPeer, UpdatePeer, RemovePeer,
  AllowPublicKey, RevokePublicKey, IsPublicKeyAllowed, IsPeerAllowed, RecordSuccess,
  RecordFailure, RecordTimeout, SelectOptimalPeer, SelectNearestPeers, Count,
  PeersByScore, AllowedPublicKeys, ListAllowedPublicKeys; transport.Start, Stop, Send,
  Connections, Broadcast, PeerConnection.Send, Close, GracefulClose
- Removed redundant inline comments that restate code (bundle.go, transport.go, worker.go)
- Added _Bad and _Ugly test categories to logging/logger_test.go to satisfy the
  TestFilename_Function_{Good,Bad,Ugly} naming convention (AX-10)
- Removed all linter-injected short-form alias files (*_compat.go, *_alias_test.go)
  that violated AX-1 (Err* aliases, Uint64Val, WithComponent, GetLevel, GetGlobal, etc.)

Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 12:20:52 +01:00
7ed9af70c2 Merge pull request '[agent/codex:gpt-5.4-mini] Update the code against the AX design principles in ~/spec/r...' (#21) from agent/update-the-code-against-the-ax-design-pr into dev
Some checks failed
Security Scan / security (push) Successful in 9s
Test / test (push) Failing after 50s
2026-03-31 05:44:44 +00:00
Virgil
1badcf1877 fix(transport): expose accepted peers before handshake ack
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 05:44:02 +00:00
Virgil
1c8592a5a0 refactor(node): align peer and handler names with AX
All checks were successful
Security Scan / security (push) Successful in 14s
Test / test (push) Successful in 1m27s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 05:32:08 +00:00
7d2ede8289 Merge pull request '[agent/codex:gpt-5.4-mini] Update the code against the AX design principles in ~/spec/r...' (#19) from agent/update-the-code-against-the-ax-design-pr into dev
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m31s
2026-03-31 05:19:05 +00:00
Virgil
aa001ce214 refactor(node): rename websocket handler and clarify UEPS comments
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 05:18:20 +00:00
Virgil
390e60860e refactor(node): remove legacy AX aliases
All checks were successful
Security Scan / security (push) Successful in 12s
Test / test (push) Successful in 1m34s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-31 05:08:09 +00:00
Virgil
79591c3635 refactor(node): trim legacy AX compatibility fields
Some checks failed
Test / test (push) Failing after 13m33s
Security Scan / security (push) Failing after 13m35s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 23:00:36 +00:00
Virgil
bd9efd1deb refactor(node): clarify AX-facing transport and worker names
All checks were successful
Security Scan / security (push) Successful in 11s
Test / test (push) Successful in 1m53s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 22:54:45 +00:00
Virgil
885070d241 refactor(node): adopt AX naming across core APIs
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m41s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 22:46:11 +00:00
Virgil
851b1294bd refactor(node): rename controller and worker core fields
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m42s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 22:38:29 +00:00
Virgil
819862a1a4 refactor(node): tighten AX naming across core paths
All checks were successful
Security Scan / security (push) Successful in 11s
Test / test (push) Successful in 1m38s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 22:31:11 +00:00
Virgil
dec79b54d6 refactor(node): clarify filesystem and buffer pool names
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m40s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:50:35 +00:00
Virgil
de8b138367 refactor(ueps): clarify layer tag names
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m38s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:39:15 +00:00
Virgil
f5d1ee6021 refactor(node): align worker interfaces with AX naming
Some checks failed
Security Scan / security (push) Successful in 9s
Test / test (push) Failing after 59s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:34:57 +00:00
Virgil
c03b3410e6 refactor(node): remove legacy compatibility aliases
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m29s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:27:45 +00:00
Virgil
7ce21cdba1 refactor(node): adopt AX-native protocol names
All checks were successful
Security Scan / security (push) Successful in 10s
Test / test (push) Successful in 1m30s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:21:07 +00:00
Snider
8e640e2d42 feat(node): advertise agent identity in transport
Some checks failed
Security Scan / security (push) Successful in 8s
Test / test (push) Failing after 36s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 22:03:34 +01:00
Virgil
ca885ff386 refactor(node): clarify AX filesystem and message names
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m31s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:52:19 +00:00
Virgil
48cd87e081 refactor(node): clarify remaining AX fixture names
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m34s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:45:55 +00:00
Virgil
cbb3f01176 refactor(node): rename test helpers for AX clarity
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m28s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:40:59 +00:00
Virgil
0ca20d53ea test(node): migrate tests to AX-native constructors
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m28s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:35:50 +00:00
Virgil
15c961a5f4 fix(controller): remove response-channel close race
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m27s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:31:23 +00:00
Snider
6a70c6f234 fix(node): surface corrupted persisted state during load
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m27s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 21:17:43 +01:00
Virgil
4c8bced1e7 refactor(node): add AX-native accessors and usage docs
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m28s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:03:06 +00:00
Snider
51b3cf120b refactor(node): AX error names and levin protocol cleanup
All checks were successful
Security Scan / security (push) Successful in 8s
Test / test (push) Successful in 1m26s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:44:42 +01:00
Virgil
c678d20608 refactor(repo): prefer AX error names
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 19:44:05 +00:00
Virgil
d9dd7940cd refactor(repo): apply AX design pass
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 19:35:49 +00:00
Virgil
2d63a8ba18 refactor(node): add AX-native aliases for component and path APIs
Some checks failed
Security Scan / security (push) Successful in 9s
Test / test (push) Failing after 52s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 19:32:26 +00:00
Snider
ddb6df55c5 docs: add AX design principles RFC for agent dispatch
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m11s
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-30 20:27:11 +01:00
9441eb4d94 Merge pull request '[agent/codex] A specs/ folder has been injected into this workspace with R...' (#14) from agent/upgrade-to-core-v0-8-0-alpha-1 into dev
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m12s
2026-03-27 20:29:46 +00:00
Virgil
82d425d01e docs(repo): populate package specs
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-27 20:28:53 +00:00
317210e120 Merge pull request '[agent/codex] Full AX v0.8.0 compliance review. Read CODEX.md and .core/re...' (#13) from agent/upgrade-to-core-v0-8-0-alpha-1 into dev
All checks were successful
Security Scan / security (push) Successful in 8s
Test / test (push) Successful in 1m6s
2026-03-27 05:11:21 +00:00
Virgil
2833607948 docs(repo): refresh AX compliance guidance
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-27 05:10:20 +00:00
Virgil
3b2105389a chore: verification pass
All checks were successful
Security Scan / security (push) Successful in 9s
Test / test (push) Successful in 1m5s
2026-03-27 03:24:39 +00:00
Virgil
d7681bf637 refactor(repo): complete AX v0.8.0 polish pass
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 16:26:18 +00:00
Virgil
04ae11da43 refactor(node): replace stdlib helpers with core primitives
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 14:37:02 +00:00
Virgil
be55b2499b chore(node): upgrade to core v0.8.0-alpha.1
Co-Authored-By: Virgil <virgil@lethean.io>
2026-03-26 14:31:25 +00:00