core/go-process
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

feat(process): relax runner success semantics

Browse source
This commit is contained in:
Virgil 2026-04-04 00:07:48 +00:00
parent 2bc6eb70d7
commit 84d07daf19
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
runner.go
View file

@ -66,7 +66,7 @@ type RunAllResult struct {
// Success returns true if all non-skipped specs passed.
func (r RunAllResult) Success() bool {
return r.Failed == 0 && r.Skipped == 0
return r.Failed == 0
}
// RunAll executes specs respecting dependencies, parallelising where possible.

4
runner_test.go
View file

@ -178,7 +178,7 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) {
})
require.NoError(t, err)
assert.False(t, result.Success())
assert.True(t, result.Success())
assert.Equal(t, 0, result.Failed)
assert.Equal(t, 2, result.Skipped)
for _, res := range result.Results {
@ -196,7 +196,7 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) {
})
require.NoError(t, err)
assert.False(t, result.Success())
assert.True(t, result.Success())
assert.Equal(t, 0, result.Failed)
assert.Equal(t, 1, result.Skipped)
require.Len(t, result.Results, 1)