core/go-process
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix(process): treat unresolved runner specs as failures

Browse source
This commit is contained in:
Virgil 2026-04-04 03:21:01 +00:00
parent c31f3faa2b
commit 86f5fadff7
2 changed files with 8 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
runner.go
View file

@ -147,7 +147,6 @@ func (r *Runner) RunAll(ctx context.Context, specs []RunSpec) (*RunAllResult, er
Name: name,
Spec: remaining[name],
ExitCode: 1,
Skipped: true,
Error: coreerr.E("Runner.RunAll", "circular dependency or missing dependency", nil),
}
}

16
runner_test.go
View file

@ -178,11 +178,11 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) {
})
require.NoError(t, err)
assert.True(t, result.Success())
assert.Equal(t, 0, result.Failed)
assert.Equal(t, 2, result.Skipped)
assert.False(t, result.Success())
assert.Equal(t, 2, result.Failed)
assert.Equal(t, 0, result.Skipped)
for _, res := range result.Results {
assert.True(t, res.Skipped)
assert.False(t, res.Skipped)
assert.Equal(t, 1, res.ExitCode)
assert.Error(t, res.Error)
}
@ -196,11 +196,11 @@ func TestRunner_RunAll_CircularDeps(t *testing.T) {
})
require.NoError(t, err)
assert.True(t, result.Success())
assert.Equal(t, 0, result.Failed)
assert.Equal(t, 1, result.Skipped)
assert.False(t, result.Success())
assert.Equal(t, 1, result.Failed)
assert.Equal(t, 0, result.Skipped)
require.Len(t, result.Results, 1)
assert.True(t, result.Results[0].Skipped)
assert.False(t, result.Results[0].Skipped)
assert.Equal(t, 1, result.Results[0].ExitCode)
assert.Error(t, result.Results[0].Error)
})