core/go-process
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

[agent/claude:opus] Fix CodeRabbit findings. Verify each against current code, f... #2

Merged
Virgil merged 1 commit from agent/fix-coderabbit-findings--verify-each-aga into main 2026-03-17 13:13:37 +00:00
Conversation 1 Commits 1 Files changed 2 +13 -10
2 changed files with 13 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
exec/exec.go
View file

@ -86,7 +86,7 @@ func (c *Cmd) Run() error {
c.logDebug("executing command")
if err := c.cmd.Run(); err != nil {
wrapped := wrapError(err, c.name, c.args)
wrapped := wrapError("Cmd.Run", err, c.name, c.args)
c.logError("command failed", wrapped)
return wrapped
}
@ -100,7 +100,7 @@ func (c *Cmd) Output() ([]byte, error) {
out, err := c.cmd.Output()
if err != nil {
wrapped := wrapError(err, c.name, c.args)
wrapped := wrapError("Cmd.Output", err, c.name, c.args)
c.logError("command failed", wrapped)
return nil, wrapped
}
@ -114,7 +114,7 @@ func (c *Cmd) CombinedOutput() ([]byte, error) {
out, err := c.cmd.CombinedOutput()
if err != nil {
wrapped := wrapError(err, c.name, c.args)
wrapped := wrapError("Cmd.CombinedOutput", err, c.name, c.args)
c.logError("command failed", wrapped)
return out, wrapped
}
@ -154,12 +154,12 @@ func RunQuiet(ctx context.Context, name string, args ...string) error {
return nil
}
func wrapError(err error, name string, args []string) error {
func wrapError(caller string, err error, name string, args []string) error {
cmdStr := name + " " + strings.Join(args, " ")
if exitErr, ok := err.(*exec.ExitError); ok {
return coreerr.E("wrapError", fmt.Sprintf("command %q failed with exit code %d", cmdStr, exitErr.ExitCode()), err)
return coreerr.E(caller, fmt.Sprintf("command %q failed with exit code %d", cmdStr, exitErr.ExitCode()), err)
}
return coreerr.E("wrapError", fmt.Sprintf("failed to execute %q", cmdStr), err)
return coreerr.E(caller, fmt.Sprintf("failed to execute %q", cmdStr), err)
}
func (c *Cmd) getLogger() Logger {

11
global_test.go
View file

@ -61,7 +61,8 @@ func TestGlobal_SetDefault(t *testing.T) {
svc, err := framework.ServiceFor[*Service](c, "process")
require.NoError(t, err)
SetDefault(svc)
err = SetDefault(svc)
require.NoError(t, err)
assert.Equal(t, svc, Default())
})
@ -88,7 +89,8 @@ func TestGlobal_ConcurrentDefault(t *testing.T) {
svc, err := framework.ServiceFor[*Service](c, "process")
require.NoError(t, err)
SetDefault(svc)
err = SetDefault(svc)
require.NoError(t, err)
// Concurrent reads of Default()
var wg sync.WaitGroup
@ -132,7 +134,7 @@ func TestGlobal_ConcurrentSetDefault(t *testing.T) {
wg.Add(1)
go func(s *Service) {
defer wg.Done()
SetDefault(s)
_ = SetDefault(s)
}(svc)
}
wg.Wait()
@ -168,7 +170,8 @@ func TestGlobal_ConcurrentOperations(t *testing.T) {
svc, err := framework.ServiceFor[*Service](c, "process")
require.NoError(t, err)
SetDefault(svc)
err = SetDefault(svc)
require.NoError(t, err)
// Concurrent Start, List, Get operations
var wg sync.WaitGroup