[agent/claude:opus] DX audit and fix. 1) Review CLAUDE.md — update any outdate... #3

Merged

Virgil merged 1 commit from agent/dx-audit-and-fix--1--review-claude-md into main

2026-03-17 08:50:12 +00:00

Virgil commented

2026-03-17 08:50:07 +00:00

Member

Task

DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run go test -cover ./... — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes.

Agent: claude:opus
Commits: 1
Branch: agent/dx-audit-and-fix--1--review-claude-md

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task DX audit and fix. 1) Review CLAUDE.md — update any outdated commands. 2) Run `go test -cover ./...` — report coverage, add tests for untested critical paths. 3) Check error handling: all errors must use coreerr.E() from go-log, not fmt.Errorf. Fix violations. 4) Check file I/O uses go-io not os.ReadFile/os.WriteFile. Fix violations. 5) Run tests to confirm. Commit fixes. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/dx-audit-and-fix--1--review-claude-md` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-17 08:50:07 +00:00

fix(dx): repair build, update CLAUDE.md, add tests for untested paths

Security Scan / security (pull_request) Failing after 9s

Details

Test / test (pull_request) Successful in 1m44s

Details

10c9e23e04

- Fix cmd/forge build failure: remove extra locales.FS arg from
  RegisterCommands (signature takes single CommandRegistration)
- Update CLAUDE.md error handling section to document coreerr.E()
  pattern (was outdated log.E/fmt.Errorf reference)
- Add security_test.go for agentci: SanitizePath, EscapeShellArg,
  SecureSSHCommand, MaskToken (coverage 56% → 68%)
- Add provider_handlers_test.go for pkg/api: category filter, nil
  guards, manifest/verify/sign bad requests (coverage 31% → 52%)
- Audit confirms: no fmt.Errorf or os.ReadFile/WriteFile in production
  code (only in test files)

Co-Authored-By: Virgil <virgil@lethean.io>