core/go-scm
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

[agent/claude:opus] Fix CodeRabbit findings from PR review. Verify each against ... #4

Closed
Virgil wants to merge 1 commit from agent/fix-coderabbit-findings-from-pr-review into main
pull from: agent/fix-coderabbit-findings-from-pr-review
merge into: core:main
Conversation 1 Commits 1 Files changed 12 +63 -23
Virgil commented 2026-03-17 10:02:50 +00:00
Member
Copy link

Task

Fix CodeRabbit findings from PR review. Verify each against current code, fix if valid, run tests. Commit: fix(coderabbit): address review findings

  1. forge/labels.go:80-91 — GetLabelByName returns any error, EnsureLabel treats all as "not found". Add ErrLabelNotFound sentinel, only create on not-found.
  2. jobrunner/handlers/tick_parent.go:11 — import alias coreerr misleading for go-log. This is intentional (go-log exports E() for errors), add comment explaining.
  3. repos/registry.go:105-150 — FindRegistry returns raw os errors. Wrap with coreerr.E().
  4. go.mod — update go 1.26.0 to go 1.26.1.
  5. cmd/scm/cmd_scm.go:14-16 — Init calls cli.RegisterCommands without locale FS. Add locales.FS parameter.
  6. marketplace/builder.go:116-125 — WriteIndex/loadFromDir use coreio.Local directly. Add Medium field to Builder.
  7. marketplace/installer.go:107-116 — DeleteAll error ignored in Remove. Capture and return it.
  8. cmd/scm/cmd_export.go:47-48 — Wrap manifest.Compile error with cli.WrapVerb.
  9. jobrunner/handlers/dispatch.go:110-116 — Early-success return missing repo/issue identifiers. Add RepoOwner, RepoName, EpicNumber.
  10. cmd/scm/cmd_compile.go:54-60 — Validate signing key length before casting.

Agent: claude:opus
Commits: 1
Branch: agent/fix-coderabbit-findings-from-pr-review

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Fix CodeRabbit findings from PR review. Verify each against current code, fix if valid, run tests. Commit: fix(coderabbit): address review findings 1. forge/labels.go:80-91 — GetLabelByName returns any error, EnsureLabel treats all as "not found". Add ErrLabelNotFound sentinel, only create on not-found. 2. jobrunner/handlers/tick_parent.go:11 — import alias coreerr misleading for go-log. This is intentional (go-log exports E() for errors), add comment explaining. 3. repos/registry.go:105-150 — FindRegistry returns raw os errors. Wrap with coreerr.E(). 4. go.mod — update go 1.26.0 to go 1.26.1. 5. cmd/scm/cmd_scm.go:14-16 — Init calls cli.RegisterCommands without locale FS. Add locales.FS parameter. 6. marketplace/builder.go:116-125 — WriteIndex/loadFromDir use coreio.Local directly. Add Medium field to Builder. 7. marketplace/installer.go:107-116 — DeleteAll error ignored in Remove. Capture and return it. 8. cmd/scm/cmd_export.go:47-48 — Wrap manifest.Compile error with cli.WrapVerb. 9. jobrunner/handlers/dispatch.go:110-116 — Early-success return missing repo/issue identifiers. Add RepoOwner, RepoName, EpicNumber. 10. cmd/scm/cmd_compile.go:54-60 — Validate signing key length before casting. **Agent:** claude:opus **Commits:** 1 **Branch:** `agent/fix-coderabbit-findings-from-pr-review` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
Virgil added 1 commit 2026-03-17 10:02:50 +00:00
fix(coderabbit): address review findings
Some checks failed
Security Scan / security (pull_request) Failing after 8s
Details
Test / test (pull_request) Failing after 59s
Details
071eca4214 
1. forge/labels: add ErrLabelNotFound sentinel, EnsureLabel only creates on not-found
2. handlers/tick_parent: add comment explaining coreerr alias for go-log
3. repos/registry: wrap raw os errors with coreerr.E() in FindRegistry
4. go.mod: bump go 1.26.0 → 1.26.1
5. cmd/scm: pass locales.FS to cli.RegisterCommands
6. marketplace/builder: add Medium field, replace coreio.Local in loadFromDir/WriteIndex
7. marketplace/installer: capture and return DeleteAll error in Remove
8. cmd/scm/export: wrap manifest.Compile error with cli.WrapVerb
9. handlers/dispatch: add RepoOwner/RepoName/EpicNumber to early-success return
10. cmd/scm/compile: validate ed25519 key length before casting

Co-Authored-By: Virgil <virgil@lethean.io>
Virgil commented 2026-03-17 10:02:54 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go-scm/cmd/scm
cmd/scm/cmd_scm.go:16:39: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
# forge.lthn.ai/core/go-scm/cmd/forge
cmd/forge/cmd_forge.go:21:41: too many arguments in call to cli.RegisterCommands
	have (func(root *cli.Command), embed.FS)
	want (cli.CommandRegistration)
ok  	forge.lthn.ai/core/go-scm/agentci	0.270s
?   	forge.lthn.ai/core/go-scm/cmd/collect	[no test files]
FAIL	forge.lthn.ai/core/go-scm/cmd/forge [build failed]
?   	forge.lthn.ai/core/go-scm/cmd/gitea	[no test files]
FAIL	forge.lthn.ai/core/go-scm/cmd/scm [build failed]
ok  	forge.lthn.ai/core/go-scm/collect	1.795s
ok  	forge.lthn.ai/core/go-scm/forge	0.606s
?   	forge.lthn.ai/core/go-scm/git	[no test files]
ok  	forge.lthn.ai/core/go-scm/gitea	0.876s
ok  	forge.lthn.ai/core/go-scm/jobrunner	0.874s
ok  	forge.lthn.ai/core/go-scm/jobrunner/forgejo	1.008s
ok  	forge.lthn.ai/core/go-scm/jobrunner/handlers	1.345s
?   	forge.lthn.ai/core/go-scm/locales	[no test files]
ok  	forge.lthn.ai/core/go-scm/manifest	1.468s
ok  	forge.lthn.ai/core/go-scm/marketplace	2.205s
ok  	forge.lthn.ai/core/go-scm/pkg/api	1.552s
ok  	forge.lthn.ai/core/go-scm/plugin	1.678s
ok  	forge.lthn.ai/core/go-scm/repos	1.819s
FAIL

Exit code: 1

PR will not be auto-merged.

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go-scm/cmd/scm cmd/scm/cmd_scm.go:16:39: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) # forge.lthn.ai/core/go-scm/cmd/forge cmd/forge/cmd_forge.go:21:41: too many arguments in call to cli.RegisterCommands have (func(root *cli.Command), embed.FS) want (cli.CommandRegistration) ok forge.lthn.ai/core/go-scm/agentci 0.270s ? forge.lthn.ai/core/go-scm/cmd/collect [no test files] FAIL forge.lthn.ai/core/go-scm/cmd/forge [build failed] ? forge.lthn.ai/core/go-scm/cmd/gitea [no test files] FAIL forge.lthn.ai/core/go-scm/cmd/scm [build failed] ok forge.lthn.ai/core/go-scm/collect 1.795s ok forge.lthn.ai/core/go-scm/forge 0.606s ? forge.lthn.ai/core/go-scm/git [no test files] ok forge.lthn.ai/core/go-scm/gitea 0.876s ok forge.lthn.ai/core/go-scm/jobrunner 0.874s ok forge.lthn.ai/core/go-scm/jobrunner/forgejo 1.008s ok forge.lthn.ai/core/go-scm/jobrunner/handlers 1.345s ? forge.lthn.ai/core/go-scm/locales [no test files] ok forge.lthn.ai/core/go-scm/manifest 1.468s ok forge.lthn.ai/core/go-scm/marketplace 2.205s ok forge.lthn.ai/core/go-scm/pkg/api 1.552s ok forge.lthn.ai/core/go-scm/plugin 1.678s ok forge.lthn.ai/core/go-scm/repos 1.819s FAIL ``` **Exit code:** 1 PR will not be auto-merged.
Virgil closed this pull request 2026-03-17 10:10:07 +00:00
Some checks failed
Security Scan / security (pull_request) Failing after 8s
Details
Test / test (pull_request) Failing after 59s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/go-scm#4
No description provided.
Delete branch "agent/fix-coderabbit-findings-from-pr-review"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?