core/go-store
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions 2

[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/store/RFC.md fully. Find features d... #138

Merged
Virgil merged 1 commit from agent/read---spec-code-core-go-store-rfc-md-fu into dev 2026-04-04 11:54:17 +00:00
Conversation 1 Commits 1 Files changed 4 +8 -8
4 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
compact_test.go
View file

@ -136,7 +136,7 @@ func TestCompact_Compact_Good_DeterministicOrderingForSameTimestamp(t *testing.T
require.NoError(t, ensureJournalSchema(storeInstance.sqliteDatabase))
committedAt := time.Now().Add(-48 * time.Hour).UnixMilli()
require.NoError(t, insertJournalEntry(
require.NoError(t, commitJournalEntry(
storeInstance.sqliteDatabase,
"events",
"session-b",
@ -144,7 +144,7 @@ func TestCompact_Compact_Good_DeterministicOrderingForSameTimestamp(t *testing.T
`{"workspace":"session-b"}`,
committedAt,
))
require.NoError(t, insertJournalEntry(
require.NoError(t, commitJournalEntry(
storeInstance.sqliteDatabase,
"events",
"session-a",

4
journal.go
View file

@ -72,7 +72,7 @@ func (storeInstance *Store) CommitToJournal(measurement string, fields map[strin
}
committedAt := time.Now().UnixMilli()
if err := insertJournalEntry(
if err := commitJournalEntry(
storeInstance.sqliteDatabase,
storeInstance.journalBucket(),
measurement,
@ -228,7 +228,7 @@ func ensureJournalSchema(database schemaDatabase) error {
return nil
}
func insertJournalEntry(
func commitJournalEntry(
executor journalExecutor,
bucket, measurement, fieldsJSON, tagsJSON string,
committedAt int64,

6
journal_test.go
View file

@ -135,7 +135,7 @@ func TestJournal_QueryJournal_Good_BucketFilter(t *testing.T) {
require.True(t,
storeInstance.CommitToJournal("session-a", map[string]any{"like": 1}, map[string]string{"workspace": "session-a"}).OK,
)
require.NoError(t, insertJournalEntry(
require.NoError(t, commitJournalEntry(
storeInstance.sqliteDatabase,
"events",
"session-b",
@ -160,7 +160,7 @@ func TestJournal_QueryJournal_Good_DeterministicOrderingForSameTimestamp(t *test
require.NoError(t, ensureJournalSchema(storeInstance.sqliteDatabase))
committedAt := time.Date(2026, 3, 30, 12, 0, 0, 0, time.UTC).UnixMilli()
require.NoError(t, insertJournalEntry(
require.NoError(t, commitJournalEntry(
storeInstance.sqliteDatabase,
"events",
"session-b",
@ -168,7 +168,7 @@ func TestJournal_QueryJournal_Good_DeterministicOrderingForSameTimestamp(t *test
`{"workspace":"session-b"}`,
committedAt,
))
require.NoError(t, insertJournalEntry(
require.NoError(t, commitJournalEntry(
storeInstance.sqliteDatabase,
"events",
"session-a",

2
workspace.go
View file

@ -471,7 +471,7 @@ func (storeInstance *Store) commitWorkspaceAggregate(workspaceName string, field
return err
}
if err := insertJournalEntry(
if err := commitJournalEntry(
transaction,
storeInstance.journalBucket(),
workspaceName,