core/go-store
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

[agent/codex:gpt-5.4-mini] Read ~/spec/code/core/go/store/RFC.md fully. Find features d... #91

Merged
Virgil merged 1 commit from agent/read---spec-code-core-go-store-rfc-md-fu into dev 2026-04-03 09:10:02 +00:00
Conversation 1 Commits 1 Files changed 2 +33 -1
2 changed files with 33 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
journal.go
View file

@ -108,7 +108,7 @@ func (storeInstance *Store) QueryJournal(flux string) core.Result {
"SELECT bucket_name, measurement, fields_json, tags_json, committed_at, archived_at FROM " + journalEntriesTableName + " WHERE archived_at IS NULL ORDER BY committed_at",
)
}
if core.HasPrefix(trimmedQuery, "SELECT") || core.HasPrefix(trimmedQuery, "select") {
if isRawSQLJournalQuery(trimmedQuery) {
return storeInstance.queryJournalRows(trimmedQuery)
}
@ -119,6 +119,13 @@ func (storeInstance *Store) QueryJournal(flux string) core.Result {
return storeInstance.queryJournalRows(selectSQL, arguments...)
}
func isRawSQLJournalQuery(query string) bool {
upperQuery := core.Upper(core.Trim(query))
return core.HasPrefix(upperQuery, "SELECT") ||
core.HasPrefix(upperQuery, "WITH") ||
core.HasPrefix(upperQuery, "EXPLAIN")
}
func (storeInstance *Store) queryJournalRows(query string, arguments ...any) core.Result {
rows, err := storeInstance.database.Query(query, arguments...)
if err != nil {

25
journal_test.go
View file

@ -35,6 +35,31 @@ func TestJournal_CommitToJournal_Good_WithQueryJournalSQL(t *testing.T) {
assert.Equal(t, "session-b", tags["workspace"])
}
func TestJournal_QueryJournal_Good_RawSQLWithCTE(t *testing.T) {
storeInstance, err := New(":memory:", WithJournal("http://127.0.0.1:8086", "core", "events"))
require.NoError(t, err)
defer storeInstance.Close()
require.True(t,
storeInstance.CommitToJournal("session-a", map[string]any{"like": 4}, map[string]string{"workspace": "session-a"}).OK,
)
rows := requireResultRows(
t,
storeInstance.QueryJournal(`
WITH journal_rows AS (
SELECT bucket_name, measurement, fields_json, tags_json, committed_at, archived_at
FROM journal_entries
)
SELECT bucket_name, measurement, fields_json, tags_json, committed_at, archived_at
FROM journal_rows
ORDER BY committed_at
`),
)
require.Len(t, rows, 1)
assert.Equal(t, "session-a", rows[0]["measurement"])
}
func TestJournal_QueryJournal_Good_FluxFilters(t *testing.T) {
storeInstance, err := New(":memory:", WithJournal("http://127.0.0.1:8086", "core", "events"))
require.NoError(t, err)