6c90af807d
30+ findings dispositioned across compact / publish / events / import / workspace / config / docs / test surfaces. Major code fixes: - compact.go: stage archive, DB commit first, publish after commit (durability ordering bug) - compact_test.go: replaced medium reread O(n²) with bytes.Buffer - coverage_test.go: EnsureScoringTables now wraps + returns DDL errors - events.go: lifecycle lock-order reordered (deadlock risk) - import.go: paths join against cfg.DataDir; SQL write errors propagate; counts increment only on success - bench_test.go: ScpDir + /benchmarks/ paths corrected - json.go: formatter write errors propagate (no silent drops) - parquet.go: removed runtime parquet-go dep + in-core writer (was buffering whole rows in memory — OOM risk on large datasets) - publish.go: PublishConfig.Public uses private: !public - HuggingFace upload streams file with content length (was buffering) - store.go: ScopedStore.Transaction nil-store panic guard - recover_test.go: handle .duckdb.wal sidecars; skip SQLite -shm for DuckDB - coverage_test.go: WriteScoringResult wraps insert failures - events_test.go: restored EventDeleteGroup wire value 'delete_group' - transaction.go: NewScopedConfigured docs include parent store arg - store_test.go: scope_test keyName uses non-wrapping integer names - import_export_test.go: testify → stdlib helpers (AX-6 conformance) - store.go: collapsed duplicate workspace DB fields to canonical 'db' Doc / config: - README.md: 'Licence' UK English on badge - docs/architecture.md: clearer event ordering + lifecycle docs - .golangci.yml: migrated to golangci-lint v2 schema - Taskfile: default includes vet task - JSON: terse 'value' param + concrete examples Disposition replies (RESOLVED-COMMENT, no code change): - conventions_test.go testify suggestion: AX-6 banned testify; stdlib helpers are convention - DuckDB CGO/MIT critical: retained as documented exception in DEPENDENCIES.md (load-bearing existing dependency for the workspace store; replacement is its own engineering ticket) Verification: GOWORK=off go vet + go test -count=1 ./... pass. golangci-lint run ./... reports 0 issues. gofmt -l clean. git diff --check clean. Closes findings on https://github.com/dAppCore/go-store/pull/4 Co-authored-by: Codex <noreply@openai.com> |
||
|---|---|---|
| .. | ||
| architecture.md | ||
| development.md | ||
| history.md | ||
| index.md | ||
| RFC-CORE-008-AGENT-EXPERIENCE.md | ||
| RFC-CORE-GO-REQUEST.md | ||
| RFC-CORE-GO.md | ||
| RFC-STORE.md | ||