core/go-webview
8
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix(console): defer limit trimming until append

Browse source 
Co-Authored-By: Virgil <virgil@lethean.io>
This commit is contained in:
Snider 2026-04-15 14:19:00 +01:00
parent f4a094e87c
commit d6fcd6a2f4
2 changed files with 13 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
console.go
View file

@ -217,7 +217,7 @@ func (cw *ConsoleWatcher) removeHandler(id int64) {
}
}
// SetLimit sets the maximum number of messages to retain.
// SetLimit replaces the retention limit for future appends.
func (cw *ConsoleWatcher) SetLimit(limit int) {
cw.mu.Lock()
defer cw.mu.Unlock()
@ -225,7 +225,6 @@ func (cw *ConsoleWatcher) SetLimit(limit int) {
limit = 0
}
cw.limit = limit
cw.messages = trimConsoleMessages(cw.messages, cw.limit)
}
// Messages returns all captured messages.

18
webview_test.go
View file

@ -809,8 +809,8 @@ func TestConsoleWatcherFilteredMessages_Good_UsesAnyActiveFilter(t *testing.T) {
}
}
// TestConsoleWatcherSetLimit_Good_TrimsExistingMessages verifies shrinking the limit trims buffered messages immediately.
func TestConsoleWatcherSetLimit_Good_TrimsExistingMessages(t *testing.T) {
// TestConsoleWatcherSetLimit_Good_AppliesToFutureWrites verifies shrinking the limit trims buffered messages on the next append.
func TestConsoleWatcherSetLimit_Good_AppliesToFutureWrites(t *testing.T) {
cw := &ConsoleWatcher{
messages: []ConsoleMessage{
{Type: "log", Text: "first"},
@ -823,11 +823,17 @@ func TestConsoleWatcherSetLimit_Good_TrimsExistingMessages(t *testing.T) {
cw.SetLimit(2)
if cw.Count() != 2 {
t.Fatalf("Expected 2 messages after trimming, got %d", cw.Count())
if cw.Count() != 3 {
t.Fatalf("Expected 3 messages to remain until the next append, got %d", cw.Count())
}
if messages := cw.Messages(); messages[0].Text != "second" || messages[1].Text != "third" {
t.Fatalf("Unexpected retained messages: %#v", messages)
cw.addMessage(ConsoleMessage{Type: "log", Text: "fourth"})
if cw.Count() != 2 {
t.Fatalf("Expected 2 messages after the next append, got %d", cw.Count())
}
if messages := cw.Messages(); messages[0].Text != "third" || messages[1].Text != "fourth" {
t.Fatalf("Unexpected retained messages after trimming: %#v", messages)
}
}