core/go
8
0
Fork 0
generated from lthn/LEM
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions
1030 commits 5 branches 44 tags 72 MiB
Commit graph

1030 commits

This branch
This branch
All branches
Author SHA1 Message Date
Snider
954cd714a1 fix: strip module prefix from coverage paths for Codecov 
Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-21 09:16:24 +00:00
Snider
b01b7f4d88 fix: add Codecov token to CI workflow 
Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-21 09:12:39 +00:00
Snider
01135ac8bd docs: rewrite README + add CI workflow with Codecov 
README reflects current API — DI framework, not the old CLI/GUI app.
CI runs tests with coverage on push to main.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-21 09:00:13 +00:00
Snider
fbd646456a refactor: flatten polyglot layout to standard Go module 
Move source from go/core/ to root, tests from go/tests/ to tests/.
Module path dappco.re/go/core resolves cleanly — builds and tests pass.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-21 08:27:14 +00:00
Snider
2fa8b32db2 go update 2026-03-21 06:25:59 +00:00
Snider
3e507c9813 go update 2026-03-20 21:35:22 +00:00
Snider
104416676b go update 2026-03-20 21:14:38 +00:00
Snider
b34899ca00 go update 2026-03-20 21:00:48 +00:00
Snider
1728c2930c refactor: update imports from forge.lthn.ai/core/go to dappco.re/go/core 
All .go imports, test fixtures, and embed.go code generation updated
to match the new module path.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 20:16:38 +00:00
Snider
41c50da68b go update 2026-03-20 19:58:41 +00:00
Snider
73eed891ca fix: CodeRabbit re-review — 3 findings resolved 
- cli: dispatch through Start for lifecycle-backed commands
- command: reject empty/malformed path segments
- error: fix typo CauseorJoin → ErrorJoin in doc comment

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 18:48:02 +00:00
Snider
af6b618196 fix: CodeRabbit review — 7 findings resolved 
- cli: preserve explicit empty flag values (--name=)
- cli: skip placeholder commands in help output
- command: fail fast on non-executable placeholder Run
- command: lifecycle-backed commands count as registered
- runtime: wrap non-error OnStop payloads in error
- fs: error on protected path deletion (was silent Result{})
- error: log crash report I/O failures instead of swallowing

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 18:36:30 +00:00
Snider
e17217a630 refactor: camelCase — waitgroup → waitGroup 
Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 18:03:31 +00:00
Snider
d5f295cb7d refactor: AX naming — wg → waitgroup, ctx → context 
Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 18:02:07 +00:00
Snider
bde8d4c7cc feat: lifecycle context — Core.Context() for cooperative shutdown 
- Core holds context.Context + CancelFunc
- New() creates background context
- ServiceStartup creates fresh context from caller's ctx (restart safe)
- ServiceShutdown cancels context before draining tasks
- c.Context() accessor lets task handlers check Done() for graceful exit

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:59:43 +00:00
Snider
629adb056b fix: lifecycle — clear shutdown flag on startup, document waiter goroutine 
- ServiceStartup clears c.shutdown so Core supports restart cycles
- ServiceShutdown waiter goroutine documented as inherent to sync.WaitGroup

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:56:21 +00:00
Snider
61b034335a fix: Codex review round 4 — panic recovery, subtree preservation 
- PerformAsync: defer/recover wraps task execution, broadcasts error on panic
- Command: preserve existing subtree when overwriting placeholder parent

Remaining known architectural:
- fs.go TOCTOU (needs openat/fd-based ops)
- Global lockMap (needs per-Core registry)
- ServiceShutdown goroutine on timeout (inherent to wg.Wait)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:52:48 +00:00
Snider
ee9e715243 fix: Codex review round 3 — 5 remaining findings 
- Command: allow overwriting auto-created parent placeholders
- NewWithFactories: wrap original factory error cause
- I18n.SetTranslator: reapply saved locale to new translator
- Options/Drive: copy slices on intake (prevent aliasing)
- Embed.path: returns Result, rejects traversal with error

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:46:47 +00:00
Snider
bf1f8e51ad fix: Codex review round 2 — path traversal, shutdown order, races 
High:
- embed.Extract: safePath validates all rendered paths stay under targetDir
- embed.path: reject .. traversal on arbitrary fs.FS
- ServiceShutdown: drain background tasks BEFORE stopping services

Medium:
- cli.Run: command lookup holds registry RLock (race fix)
- NewWithFactories: propagate factory/registration failures

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:35:09 +00:00
Snider
4c3a671b48 fix: Codex review — medium/low severity issues resolved 
Medium:
- Config zero-value safe (nil ConfigOptions guards on all mutators)
- ServiceShutdown collects and returns first OnStop error
- Default logger uses atomic.Pointer (race fix)
- Command registration rejects duplicates (like Service)

Low:
- Array.AsSlice returns copy, not backing slice
- fs.validatePath constructs error on sandbox escape (was nil)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:25:12 +00:00
Snider
f1bd36db2e fix(critical): Codex review — 7 high-severity issues resolved 
Critical:
- Result.Result() zero args returns receiver instead of panicking

High:
- i18n.SetLanguage: added mutex, forwards to translator
- embed.GetAsset: hold RLock through assets map read (race fix)
- cli.PrintHelp: safe type assertion on Translate result
- task.PerformAsync: guard nil task in reflect.TypeOf
- Service/Command registries initialised in New() (race fix)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 17:20:08 +00:00
Snider
bc06480b58 fix: AX audit round 7 — Err.Err renamed to Err.Cause 
Remaining 32 Rule 1 violations are valid but not P0:
- Subsystem accessors returning typed pointers (fluent API)
- Error creators returning error (should return Result)
- Void fire-and-forget operations (Must, Progress, Log)
- Iterator returning iter.Seq (should use modern Go patterns)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 16:54:27 +00:00
Snider
2f39e8e1f4 fix: AX audit round 6 — Result returns, naming, literal style 
- Data.Get, Drive.Get → Result (was typed pointers)
- I18n.Translator, I18n.Locales → Result
- Translator interface: Translate returns Result
- Array.Filter → Result, Core.Embed → Result
- Embed.BaseDir → BaseDirectory
- TaskState.ID → Identifier, SetTaskIdentifier method fix
- fs.go: Result{nil, true} → Result{OK: true} (5 lines)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 16:46:39 +00:00
Snider
298322ed89 fix: AX audit round 5 — full naming, Result returns throughout 
Renames (via GoLand refactor):
- Option.K → Key, Option.V → Value
- Err.Op → Operation, Err.Msg → Message, Err.Err → Error
- CrashSystem.OS → OperatingSystem, Arch → Architecture
- TaskID → TaskIdentifier, TaskWithID → TaskWithIdentifier
- Ipc → IPC, BaseDir → BaseDirectory
- ServiceRuntime.Opts → Options

Return type changes:
- Options.Get, Config.Get → Result (was (any, bool))
- Embed.ReadDir → Result (was ([]fs.DirEntry, error))
- Translator.Translate, I18n.Translate → Result (was string)

Rule 6:
- data.go: propagate opts.Get failure, typed error for bad fs.FS

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 16:32:43 +00:00
Snider
cf25af1a13 fix: AX audit round 4 — semantic naming, Result returns 
- Op → Operation, AllOps → AllOperations (no abbreviations)
- Translator.T → Translator.Translate (avoids testing.T confusion)
- Lock.Mu → Lock.Mutex, ServiceRuntime.Opts → .Options
- ErrorLog.Error/Warn return Result instead of error
- ErrorPanic.Reports returns Result instead of ([]CrashReport, error)
- Core.LogError/LogWarn simplified to passthrough

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 16:00:41 +00:00
Snider
b2d0deb99b fix: AX audit round 3 — 8 violations resolved 
- core.go: Result{Value: wrapped} → Result{wrapped, false} (explicit failure)
- error.go: fmt.Sprint → Sprint wrapper, removed fmt import
- fs.go: Stat/Open propagate validatePath failures (return vp)
- lock.go: Startables/Stoppables return Result
- task.go: PerformAsync returns Result
- runtime.go: updated to unwrap Result from Startables/Stoppables

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 15:49:33 +00:00
Snider
8801e2ea10 fix: final AX audit — 9 remaining violations resolved 
- fs.go: propagate validatePath failures (return vp) instead of bare Result{}
- app.go: Find() returns Result instead of *App
- log.go: fmt import removed — uses Sprint/Sprintf/Print from string.go/utils.go
- string.go: added Sprint() and Sprintf() wrappers for any-to-string formatting

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 15:43:19 +00:00
Snider
f8e1459bd1 fix: AX audit — eloquent Result literals, renamed abbreviations, error propagation 
- Result{x, true} positional literals replace verbose Result{Value: x, OK: true}
- Result{err, false} replaces bare Result{} where errors were swallowed
- ErrCode → ErrorCode, LogPan → LogPanic (no abbreviations)
- NewBuilder()/NewReader() wrappers in string.go, removed strings import from embed.go
- fmt.Errorf in log.go replaced with NewError(fmt.Sprint(...))
- 14 files, 66 audit violations resolved

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 15:36:33 +00:00
Snider
a845866c25 fix: embed.go Result{}.Result() pattern + utils test coverage 
- embed.go: replace 27 manual Result{} constructions with Result{}.Result()
  — errors now propagate instead of being silently swallowed
- utils_test.go: add 22 tests for IsFlag, Arg, ArgString, ArgInt, ArgBool,
  and Result.Result() (252 tests, 78.8% coverage)

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 15:25:37 +00:00
Snider
b0ec660e78 fix: fs.go use Result{}.Result() return value, i18n uses i.locale 
fs.go: Value receiver Result() returns new Result — must use return
value not discard it. Changed from r.Result(...); return *r to
return Result{}.Result(os.ReadDir(...)).

i18n: SetLanguage sets i.locale directly. Language() reads i.locale.
Translator reload is core/go-i18n's responsibility.

231 tests passing.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 15:13:36 +00:00
Snider
9bcb367dd0 feat: Command() and i18n.SetLanguage() return Result 
Command(path, Command{Action: handler}) — typed struct input, Result output.
Command fields exported: Name, Description, Path, Action, Lifecycle, Flags, Hidden.

i18n.SetLanguage returns Result instead of error.

All public methods across core/go now return Result where applicable.

231 tests, 76.5% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:44:29 +00:00
Snider
3bab201229 feat: fs.go returns Result throughout 
All 14 public Fs methods return Result instead of (value, error).
validatePath returns Result internally.

Tests updated to use r.OK / r.Value pattern.

231 tests, 77.1% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:37:06 +00:00
Snider
7d34436fc6 feat: Result.Result() — unified get/set, AX pattern 
Zero args returns Value. With args, sets Value from Go (value, error).

r.Result()            // get
r.Result(file, err)   // set — OK = err == nil
r.Result(value)       // set — OK = true

One method. Get and set. Same pattern as Service(), Command().

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:33:26 +00:00
Snider
9161ed2a79 refactor: Result.New() and Result.Result() — pointer receiver, AX pattern 
New() sets Value/OK on the receiver and returns *Result.
Result() returns the Value. Both pointer receivers.

r := &Result{}
r.New(file, err)  // OK = err == nil
val := r.Result()

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:32:16 +00:00
Snider
01dec6dbe7 feat: Result.New() — maps Go (value, error) to Result 
Result{}.New(file, err)  // OK = err == nil, Value = file
Result{}.New(value)      // OK = true, Value = value
Result{}.New()           // OK = false

Enables: return Result{}.New(s.fsys.Open(path))
Replaces manual if err != nil { return Result{} } blocks.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:27:12 +00:00
Snider
2d6415b3aa feat: embed.go and data.go return Result throughout 
Mount, MountEmbed, Open, ReadFile, ReadString, Sub, GetAsset,
GetAssetBytes, ScanAssets, GeneratePack, Extract → all return Result.

Data.ReadFile, ReadString, List, ListNames, Extract → Result.
Data.New uses Mount's Result internally.

Internal helpers (WalkDir callback, copyFile) stay error — they're
not public API.

231 tests, 77.4% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 14:13:47 +00:00
Snider
94f2e54abe feat: IPC, task, lifecycle all return Result 
Action, Query, QueryAll, Perform → Result
QueryHandler, TaskHandler → func returning Result
RegisterAction/RegisterActions → handler returns Result
ServiceStartup, ServiceShutdown → Result
LogError, LogWarn → Result
ACTION, QUERY, QUERYALL, PERFORM aliases → Result

Tests updated to match new signatures.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 13:59:45 +00:00
Snider
f5611b1002 refactor: AX audit fixes — no direct strings/fmt, full type names 
Direct strings import removed from: data.go, error.go, fs.go
  → uses Split, SplitN, TrimPrefix, TrimSuffix, HasPrefix, Replace, Contains, Join

Direct fmt import removed from: fs.go
  → uses Print() from utils.go

fmt.Errorf in panic recovery → NewError(fmt.Sprint("panic: ", r))

Abbreviated type names renamed:
  ConfigOpts → ConfigOptions
  LogOpts → LogOptions
  RotationLogOpts → RotationLogOptions

embed.go keeps strings import (strings.NewReader, strings.Builder).
error.go keeps fmt import (fmt.Sprint for panic values).

232 tests, 77.8% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 13:47:23 +00:00
Snider
cb16b63b19 refactor: replace fmt.Sprintf in errors with Join/Concat 
All error message string building now uses core string primitives.
Remaining fmt usage: code generation (%q quoting) and log formatting (%v).

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 13:38:53 +00:00
Snider
5d67088080 feat: Service as typed struct, Result without generics 
Service is now a proper struct with OnStart/OnStop/OnReload lifecycle
functions — not a registry wrapping any. Packages create Service{} with
typed fields, same pattern as Command and Option.

Result drops generics — Value is any. The struct is the container,
Value is the generic. No more Result[T] ceremony.

Service(name, Service{}) to register, Service(name) to get — both
return Result. ServiceFactory returns Result not (any, error).

NewWithFactories/NewRuntime return Result.

232 tests, 77.8% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 13:30:22 +00:00
Snider
996853bd53 refactor: Command and Service use Arg() for type-checked extraction 
Both registries now use Arg(0, args...) instead of ArgString directly.
Type checking flows through Arg's switch before assertion.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:52:19 +00:00
Snider
4cc2e5bf15 refactor: Arg(index, args...) — type-checks then delegates 
Arg() detects the type at index and delegates to ArgString/ArgInt/ArgBool.
Index-first, args variadic. Typed extractors validate with ok check.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:50:59 +00:00
Snider
0c97415d77 feat: Arg() type-checked extractor — delegates to ArgString/ArgInt/ArgBool 
core.Arg(args, 0) returns any with bounds check.
ArgString/ArgInt/ArgBool delegate through Arg() for type detection.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:46:52 +00:00
Snider
02d966d184 feat: ArgString helper — safe variadic any→string extraction 
core.ArgString(args, 0) replaces args[0].(string) pattern.
Bounds-checked, returns empty string on miss or wrong type.
Used by Command() and Service() registries.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:44:57 +00:00
Snider
f1d6c2a174 feat: Join() reclaimed for strings — ErrorJoin for errors 
core.Join("/", "deploy", "to", "homelab") → "deploy/to/homelab"
core.Join(".", "cmd", "deploy", "description") → "cmd.deploy.description"

Join builds via Concat — same hook point for security/validation.
errors.Join wrapper renamed to ErrorJoin.
JoinPath now delegates to Join("/", ...).

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:42:10 +00:00
Snider
2fab391cc9 feat: Concat() string helper — hook point for validation/security 
core.Concat("cmd.", key, ".description") — variadic string builder.
Gives a single point to add sanitisation, injection checks, or
encoding later. command.go I18nKey uses it.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:34:38 +00:00
Snider
e12526dca6 feat: string.go — core string primitives, same pattern as array.go 
HasPrefix, HasSuffix, TrimPrefix, TrimSuffix, Contains, Split, SplitN,
StringJoin, Replace, Lower, Upper, Trim, RuneCount.

utils.go and command.go now use string.go helpers — zero direct
strings import in either file.

234 tests, 79.8% coverage.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:29:15 +00:00
Snider
c8ebf40e78 feat: IsFlag helper — cli.go now has zero string imports 
core.IsFlag(arg) checks if an argument starts with a dash.
Cli.go no longer imports strings — all string ops via utils.go helpers.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:24:39 +00:00
Snider
c3f457c151 feat: JoinPath helper — joins segments with / 
core.JoinPath("deploy", "to", "homelab") → "deploy/to/homelab"
Cli.Run uses it for command path resolution.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:23:05 +00:00
Snider
e220b9faab rename: Printl → Print 
Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-20 12:20:36 +00:00