core/go
8
0
Fork 0
generated from lthn/LEM
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

[agent/claude:haiku] Review all files in pkg/core/. Report findings with file:lin... #19

Closed
Virgil wants to merge 1 commit from agent/review-all-files-in-pkg-core---report-fi into dev
pull from: agent/review-all-files-in-pkg-core---report-fi
merge into: core:dev
Conversation 3 Commits 1 Files changed 1 +10920 -124527
Virgil commented 2026-03-18 14:41:55 +00:00
Member
Copy link

Task

Review all files in pkg/core/. Report findings with file:line format. Focus on your area of expertise.

Agent: claude:haiku
Commits: 1
Branch: agent/review-all-files-in-pkg-core---report-fi

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Review all files in pkg/core/. Report findings with file:line format. Focus on your area of expertise. **Agent:** claude:haiku **Commits:** 1 **Branch:** `agent/review-all-files-in-pkg-core---report-fi` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>
Virgil added 1 commit 2026-03-18 14:41:55 +00:00 
Key issues identified:
- CRITICAL: CLI subsystem uninitialised (rootCommand/bannerFunction nil)
- CRITICAL: Concurrent map race in GetAsset (embed.go)
- CRITICAL: Package-level lock map violates Core instance isolation
- HIGH: Lock-order violation between service and i18n mutexes
- HIGH: Data race on defaultLog pointer replacement
- HIGH: File I/O convention violations in crash reporting

Comprehensive analysis with fix recommendations and priority ordering.

Co-Authored-By: Virgil <virgil@lethean.io>
Virgil commented 2026-03-18 14:41:56 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

# forge.lthn.ai/core/go/tests_test [forge.lthn.ai/core/go/tests.test]
tests/async_test.go:89:14: rt.Core.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/async_test.go:103:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/async_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:47:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:49:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:51:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:92:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:94:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:119:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:119:8: too many errors
?   	forge.lthn.ai/core/go/pkg/core	[no test files]
FAIL	forge.lthn.ai/core/go/tests [build failed]
FAIL

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` # forge.lthn.ai/core/go/tests_test [forge.lthn.ai/core/go/tests.test] tests/async_test.go:89:14: rt.Core.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/async_test.go:103:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/async_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:47:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:49:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:51:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:92:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:94:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:119:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:119:8: too many errors ? forge.lthn.ai/core/go/pkg/core [no test files] FAIL forge.lthn.ai/core/go/tests [build failed] FAIL ``` **Exit code:** 1
Virgil commented 2026-03-18 14:41:57 +00:00
Author
Member
Copy link

Verification Failed

Command: go test ./...

?   	forge.lthn.ai/core/go/pkg/core	[no test files]
# forge.lthn.ai/core/go/tests_test [forge.lthn.ai/core/go/tests.test]
tests/async_test.go:89:14: rt.Core.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/async_test.go:103:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/async_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:47:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:49:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:51:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:92:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:94:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:119:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService)
tests/core_lifecycle_test.go:119:8: too many errors
FAIL	forge.lthn.ai/core/go/tests [build failed]
FAIL

Exit code: 1

## Verification Failed **Command:** `go test ./...` ``` ? forge.lthn.ai/core/go/pkg/core [no test files] # forge.lthn.ai/core/go/tests_test [forge.lthn.ai/core/go/tests.test] tests/async_test.go:89:14: rt.Core.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/async_test.go:103:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/async_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:47:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:49:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:51:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:92:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:94:10: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:118:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:119:8: c.RegisterService undefined (type *core.Core has no field or method RegisterService) tests/core_lifecycle_test.go:119:8: too many errors FAIL forge.lthn.ai/core/go/tests [build failed] FAIL ``` **Exit code:** 1
Virgil added the
needs-review
 label 2026-03-18 14:41:57 +00:00
Virgil commented 2026-03-18 14:41:57 +00:00
Author
Member
Copy link

Needs Review

Tests failed after rebase. Auto-merge gave up after retry.

Labelled needs-review for human attention.

## Needs Review Tests failed after rebase. Auto-merge gave up after retry. Labelled `needs-review` for human attention.
Virgil changed target branch from main to dev 2026-03-24 11:12:18 +00:00
Virgil closed this pull request 2026-03-24 11:19:20 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review

   
needs-review
  
athena

Assign to Athena AI agent (M3 Ultra)

  
athena-gemini

Dispatch to Gemini CLI on M3 Ultra

  
audit

Code audit task

  
clotho

Assign to Clotho AI agent for processing

  
clotho-gemini

Dispatch to Gemini CLI on darbs (AU)

  
codex

Dispatch to Codex CLI on gateway for analysis

  
darbs-claude

Dispatch to Claude on darbs (AU)

  
security

Security review task

  
wiki

Documentation/wiki update

No labels
needs-review
needs-review
needs-review
needs-review
needs-review
needs-review
needs-review
athena
athena-gemini
audit
clotho
clotho-gemini
codex
darbs-claude
security
wiki
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: core/go#19
No description provided.
Delete branch "agent/review-all-files-in-pkg-core---report-fi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?