Snider
|
e87f066215
|
docs(core): comprehensive review of pkg/core/ — 3 critical, 4 high, 3 medium, 2 low findings
Key issues identified:
- CRITICAL: CLI subsystem uninitialised (rootCommand/bannerFunction nil)
- CRITICAL: Concurrent map race in GetAsset (embed.go)
- CRITICAL: Package-level lock map violates Core instance isolation
- HIGH: Lock-order violation between service and i18n mutexes
- HIGH: Data race on defaultLog pointer replacement
- HIGH: File I/O convention violations in crash reporting
Comprehensive analysis with fix recommendations and priority ordering.
Co-Authored-By: Virgil <virgil@lethean.io>
|
2026-03-18 14:41:47 +00:00 |
|