[agent/codex] Review PR #28. Read CLAUDE.md first. Check: 1) API contract ... #29

Merged

Virgil merged 702 commits from agent/review-pr--28--read-claude-md-first--che into dev

2026-03-24 16:53:52 +00:00

Virgil commented

2026-03-24 16:53:50 +00:00

Member

Task

Review PR #28. Read CLAUDE.md first. Check: 1) API contract correctness — does New() returning Result break any patterns? 2) Backward compatibility — are all callers updated? 3) WithService factory pattern — does it correctly pass Core to factories? 4) Test coverage — are the new With functions tested? 5) Error handling — does the opts loop correctly short-circuit on failure? Report ALL findings with file:line references.

Agent: codex
Commits: 1
Branch: agent/review-pr--28--read-claude-md-first--che

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Review PR #28. Read CLAUDE.md first. Check: 1) API contract correctness — does New() returning Result break any patterns? 2) Backward compatibility — are all callers updated? 3) WithService factory pattern — does it correctly pass *Core to factories? 4) Test coverage — are the new With* functions tested? 5) Error handling — does the opts loop correctly short-circuit on failure? Report ALL findings with file:line references. **Agent:** codex **Commits:** 1 **Branch:** `agent/review-pr--28--read-claude-md-first--che` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-24 16:53:50 +00:00

feat: restore functional option pattern for New() c45b22849f

New() returns Result, accepts CoreOption functionals.
Restores v0.3.3 service registration contract:
- WithService(factory func(*Core) Result) — service factory receives Core
- WithOptions(Options) — key-value configuration
- WithServiceLock() — immutable after construction

Services registered in New() form the application conclave with
shared IPC access. Each Core instance has its own bus scope.

Co-Authored-By: Virgil <virgil@lethean.io>