[agent/codex] Review PR #28 (fresh workspace). Run: git log --oneline -3 F... #31

Closed

Virgil wants to merge 1 commit from agent/review-pr--28--fresh-workspace---run--gi into dev

Virgil commented

2026-03-24 17:13:53 +00:00

Member

Task

Review PR #28 (fresh workspace). Run: git log --oneline -3 FIRST to confirm you are on commit b5dcdbb. Check: 1) WithOptions at contract.go — does it copy the Options slice? 2) WithService — does it have reflect-based auto-discovery and HandleIPCEvents registration? 3) core_test.go — is there a failing option short-circuit test? 4) Any new issues? Report ALL findings with file:line references.

Agent: codex
Commits: 2
Branch: agent/review-pr--28--fresh-workspace---run--gi

Auto-created by core-agent dispatch system.
Co-Authored-By: Virgil virgil@lethean.io

## Task Review PR #28 (fresh workspace). Run: git log --oneline -3 FIRST to confirm you are on commit b5dcdbb. Check: 1) WithOptions at contract.go — does it copy the Options slice? 2) WithService — does it have reflect-based auto-discovery and HandleIPCEvents registration? 3) core_test.go — is there a failing option short-circuit test? 4) Any new issues? Report ALL findings with file:line references. **Agent:** codex **Commits:** 2 **Branch:** `agent/review-pr--28--fresh-workspace---run--gi` --- Auto-created by core-agent dispatch system. Co-Authored-By: Virgil <virgil@lethean.io>

Virgil added 1 commit 2026-03-24 17:13:53 +00:00

fix: address Codex review findings on PR #28 b5dcdbb216

- WithOptions copies the Options slice (constructor isolation regression)
- WithService auto-discovers service name from package path via reflect
- WithService auto-registers HandleIPCEvents if present (v0.3.3 parity)
- Add test for failing option short-circuit in New()

Co-Authored-By: Virgil <virgil@lethean.io>

Virgil commented

2026-03-24 17:13:55 +00:00

Author

Member