core/go
8
0
Fork 0
generated from lthn/LEM
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

[agent/codex] Review PR #28 (fourth pass at commit 3a9ac82). Run git log -... #32

Closed
Virgil wants to merge 2 commits from agent/review-pr--28--fourth-pass-at-commit-3a9 into dev
pull from: agent/review-pr--28--fourth-pass-at-commit-3a9
merge into: core:dev
Conversation 3 Commits 2 Files changed 2 +13729 -126183

2 commits

Author SHA1 Message Date
Snider
3a9ac82275 fix: prevent double IPC registration + empty service placeholder 
- HandleIPCEvents only auto-registered for services the factory didn't
  register itself (prevents double handler registration)
- Auto-discovery only creates Service{} placeholder when factory didn't
  call c.Service() — factories that register themselves keep full lifecycle

Addresses Codex review findings 1 and 2 from third pass.

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-24 17:14:51 +00:00
Snider
b5dcdbb216 fix: address Codex review findings on PR #28 
- WithOptions copies the Options slice (constructor isolation regression)
- WithService auto-discovers service name from package path via reflect
- WithService auto-registers HandleIPCEvents if present (v0.3.3 parity)
- Add test for failing option short-circuit in New()

Co-Authored-By: Virgil <virgil@lethean.io>
 2026-03-24 16:59:33 +00:00