Plans 1-5 complete for core/go scope. 456 tests, 84.4% coverage, 100% AX-7 naming.
Critical bugs (Plan 1):
- P4-3+P7-3: ACTION broadcast calls all handlers with panic recovery
- P7-2+P7-4: RunE() with defer ServiceShutdown, Run() delegates
- P3-1: Startable/Stoppable return Result (breaking, clean)
- P9-1: Zero os/exec — App.Find() rewritten with os.Stat+PATH
- I3: Embed() removed, I15: New() comment fixed
- I9: CommandLifecycle removed → Command.Managed field
Registry[T] (Plan 2):
- Universal thread-safe named collection with 3 lock modes
- All 5 registries migrated: services, commands, drive, data, lock
- Insertion order preserved (fixes P4-1)
- c.RegistryOf("name") cross-cutting accessor
Action/Task system (Plan 3):
- Action type with Run()/Exists(), ActionHandler signature
- c.Action("name") dual-purpose accessor (register/invoke)
- TaskDef with Steps — sequential chain, async dispatch, previous-input piping
- Panic recovery on all Action execution
- broadcast() internal, ACTION() sugar
Process primitive (Plan 4):
- c.Process() returns Action sugar — Run/RunIn/RunWithEnv/Start/Kill/Exists
- No deps added — delegates to c.Action("process.*")
- Permission-by-registration: no handler = no capability
Missing primitives (Plan 5):
- core.ID() — atomic counter + crypto/rand suffix
- ValidateName() / SanitisePath() — reusable validation
- Fs.WriteAtomic() — write-to-temp-then-rename
- Fs.NewUnrestricted() / Fs.Root() — legitimate sandbox bypass
- AX-7: 456/456 tests renamed to TestFile_Function_{Good,Bad,Ugly}
Co-Authored-By: Virgil <virgil@lethean.io>
6.1 KiB
RFC Plan — How to Work With This Spec
For future Claude sessions. Read this FIRST before touching code.
What Exists
docs/RFC.md— 3,845-line API spec with 108 findings across 13 passesdocs/RFC.implementation.{1-6}.md— ordered implementation plansllm.txt— agent entry pointCLAUDE.md— session-specific instructions
The 108 Findings Reduce to 5 Root Causes
-
Type erasure (16 findings) —
Result{Value: any}loses compile-time safety. Mitigate with typed methods + AX-7 tests. Not fixable without abandoning Result. -
No internal boundaries (14 findings) —
*Coregrants God Mode. Solved by porting RFC-004 (Entitlements) from CorePHP. v0.9.0 work. -
Synchronous everything (12 findings) — IPC dispatch blocks. ACTION cascade in core/agent blocks queue for minutes. Fixed by Action/Task system (Plan 3).
-
No recovery path (10 findings) —
os.Exitbypasses defer. No cleanup on failure. Fixed by Plan 1 (defer + RunE + panic recovery). -
Missing primitives (8 findings) — No ID, validation, health, atomic writes. Fixed by Plan 5.
Implementation Order
Plan 1 → v0.7.1 (ship immediately, zero breakage)
Plan 2 → Registry[T] (foundation — Plans 3-4 depend on this)
Plan 3 → Action/Task (execution primitive — Plan 4 depends on this)
Plan 4 → c.Process() (needs go-process v0.7.0 update first)
Plan 5 → Missing primitives + AX-7 (independent, do alongside 2-4)
Plan 6 → Ecosystem sweep (after 1-5, dispatched via Codex)
3 Critical Bugs — Fix First
-
P4-3:
ipc.go— ACTION handler returning!OKstops entire broadcast chain. Other handlers never fire. Fix: call all handlers, don't stop on failure. -
P6-1: core/agent
handlers.go— Nestedc.ACTION()calls create synchronous cascade 4 levels deep. QA → PR → Verify → Merge blocks Poke handler for minutes. Queue doesn't drain. Fix: replace with Task pipeline (needs Plan 3). -
P7-2:
core.go—Run()callsos.Exit(1)on startup failure without callingServiceShutdown(). Running services leak. Fix: adddefer c.ServiceShutdown()+ replaceos.Exitwith error return.
Key Design Decisions Already Made
- CamelCase = primitive (brick), UPPERCASE = convenience (sugar)
- Core is Lego bricks — export the bricks, hide the safety mechanisms
- Fs.root is the ONE exception — security boundaries stay unexported
- Registration IS permission — no handler = no capability
errorat Go interface boundary,Resultat Core contract boundary- Dual-purpose methods (Service, Command, Action) — keep as sugar, Registry has explicit Get/Set
- Array[T] and ConfigVar[T] are guardrail primitives — model-proof, not speculative
- ServiceRuntime[T] and manual
.core = care both valid — document both - Startable returns Result — clean break, no V2 compat shim (pre-v1, breaking is expected)
RunE()alongsideRun()— no breakage- CommandLifecycle removed — replaced with
Command.Managedstring field
Existing RFCs That Solve Open Problems
| Problem | RFC | Core Provides | Consumer Implements |
|---|---|---|---|
| Permissions | RFC-004 Entitlements | c.Entitlement() interface |
go-entitlements package |
| Config context | RFC-003 Config Channels | c.Config() with channel |
config channel service |
| Secrets | RFC-012 SMSG | c.Secret() interface |
go-smsg / env fallback |
| Validation | RFC-009 Sigil | Transform chain interface | validator implementations |
| Containers | RFC-014 TIM | c.Fs() sandbox |
TIM = OS isolation |
| In-memory fs | RFC-013 DataNode | c.Data() mounts fs.FS |
DataNode / Borg |
| Lazy startup | RFC-002 Event Modules | Event declaration | Lazy instantiation |
Core stays stdlib-only. Consumers bring implementations via WithService.
What NOT to Do
- Don't add dependencies to core/go (it's stdlib + go-io + go-log only)
- Don't use
os/exec— go-process is the only allowed user (P9-1: core/go itself violates this in app.go — fix it) - Don't use
unsafe.Pointeron Core types — add legitimate APIs instead - Don't call
os.Exitinside Core — return errors, let main() exit - Don't create global mutable state — use Core's Registry
- Don't auto-discover via reflect — use explicit registration (HandleIPCEvents is the last magic method)
AX-7 Status
- core/agent: 92% (840 tests, 79.9% coverage)
- core/go: 100% (457 tests, 84.4% coverage) — renamed 2026-03-25
- All 457 tests have
TestFile_Function_{Good,Bad,Ugly}naming
What Was Shipped (2026-03-25 session)
Plans 1-5 complete for core/go scope. 457 tests, 84.4% coverage, 100% AX-7 naming.
- P4-3 + P7-3: ACTION broadcast — calls all handlers, panic recovery per handler
- P7-2 + P7-4:
RunE()withdefer ServiceShutdown,Run()delegates - P3-1: Startable/Stoppable return
Result(breaking, clean — no V2) - P9-1: Zero
os/execin core/go —App.Find()rewritten withos.Stat+ PATH - P11-2:
Fs.NewUnrestricted()— legitimate door replaces unsafe.Pointer - P4-10:
Fs.WriteAtomic()— write-to-temp-then-rename - I3:
Embed()removed, I15:New()comment fixed - I9:
CommandLifecycleinterface removed →Command.Managedstring field - Section 17:
c.Process()primitive (Action sugar, no deps) - Section 18:
c.Action("name")+ActionDef+c.Task("name", TaskDef{Steps})composition - Section 20:
Registry[T]+ all 5 migrations (services, commands, drive, data, lock) - Section 20.4:
c.RegistryOf("name")cross-cutting accessor - Plan 5:
core.ID(),ValidateName(),SanitisePath()
Session Context That Won't Be In Memory
- The ACTION cascade (P6-1) — core/go now has TaskDef for the fix, core/agent needs to wire it
- status.json has 51 unprotected read-modify-write sites (P4-9) —
WriteAtomicexists, core/agent needs to use it core.Env("DIR_HOME")is cached at init —t.Setenvdoesn't override it (P2-5) — useCORE_WORKSPACEin tests- go-process
NewServicereturns(any, error)notcore.Result— needs v0.7.0 update (go-process repo) - Multiple Core instances share global state (assetGroups, systemInfo, defaultLog)